Bug 1401655 - Run clients_daily and experiments_daily #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per issue mozilla#155
mreid-moz
force-pushed
the
clientsdaily_bug1401655
branch
from
1757336
to
f59fd16
Compare
Change the Makefile to pass through environment variables for AWS credentials, and update the docs to mention running the db migration target.
mreid-moz
force-pushed
the
clientsdaily_bug1401655
branch
from
f59fd16
to
ae6ef5a
Compare
|
I was able to run both tasks locally using the updated instructions / Makefile, however both tasks had the same strange behaviour: After a while, both encountered "Resetting dropped connection", then didn't update any further. Meanwhile, the task itself appeared to run to successful completion on EMR (with the Also note that I gave all the existing tasks meaningful names in a separate commit before adding the two new tasks. |
sunahsuh
approved these changes
Sep 29, 2017
| @@ -30,7 +30,7 @@ redis-cli: | |||
| docker-compose run redis redis-cli -h redis | |||
|
|
|||
| run: | |||
| docker-compose run web airflow $(COMMAND) | |||
| docker-compose run -e AWS_SECRET_ACCESS_KEY -e AWS_ACCESS_KEY_ID web airflow $(COMMAND) | |||
There was a problem hiding this comment.
It might be more generally applicable to add the env variables in https://github.com/mozilla/telemetry-airflow/blob/master/docker-compose.yml -- that way the keys will be passed in to all the compose-based commands
There was a problem hiding this comment.
Hm, I'm going to punt on this for now, since I'm not sure if we want to automatically pass the through more generally when spinning up the stack. I'll file an issue to follow up.
|
Experiments daily currently processes all the experiments data each time (not incrementally by day). Changing it to process incrementally is on my todo list. |
|
Adding a comment for posterity -- the errors are probably fine: we see these a lot in the normal course of a job, and I think because of the way jobs are normally run (via celery workers) they're resilient to these dropped connections while the test run is not so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also addresses #155, at least for the
main_summaryDAG.This needs to land after the associated PR over in python_mozetl, and I need to test this first, so please hold off on reviewing.