Skip to content
Permalink
Browse files

Don't hash Avro types in Longitudinal

Calling toSet on the avro types was causing a failed lookup,
hitting https://issues.apache.org/jira/browse/AVRO-1146.

We didn't need them, since the distinct List can be iterated
over without transforming into a set.
  • Loading branch information
fbertsch committed Jul 20, 2018
1 parent c02d622 commit 8a8525b5a980908907b63f38017f82fa4ea10ab8
Showing with 4 additions and 4 deletions.
  1. +4 −4 src/main/scala/com/mozilla/telemetry/views/Longitudinal.scala
@@ -741,7 +741,7 @@ object LongitudinalView {
histogramDefinitions: Map[String, HistogramDefinition]) {
val histogramsList = payloads.map(Histograms.stripKeyedHistograms)

val uniqueKeys = histogramsList.flatMap(x => x.keys).distinct.toSet
val uniqueKeys = histogramsList.flatMap(x => x.keys).distinct

val validKeys = for {
key <- uniqueKeys
@@ -758,7 +758,7 @@ object LongitudinalView {
}
}

val uniqueLabels = keyedHistogramsList.flatMap(x => x.keys).distinct.toSet
val uniqueLabels = keyedHistogramsList.flatMap(x => x.keys).distinct
val vectorized = for {
label <- uniqueLabels
vector = vectorizeHistogram(label, definition, keyedHistogramsList, histogramSchema)
@@ -772,7 +772,7 @@ object LongitudinalView {
histogramDefinitions: Map[String, HistogramDefinition]) {
val histogramsList = payloads.map(Histograms.stripHistograms)

val uniqueKeys = histogramsList.flatMap(x => x.keys).distinct.toSet
val uniqueKeys = histogramsList.flatMap(x => x.keys).distinct

val validKeys = for {
key <- uniqueKeys
@@ -903,7 +903,7 @@ object LongitudinalView {
}
}

val uniqueLabels = keyedScalarsList.flatMap(x => x.keys).distinct.toSet
val uniqueLabels = keyedScalarsList.flatMap(x => x.keys).distinct
val vectorized = for {
label <- uniqueLabels
vector = vectorizeScalar(label, definition, keyedScalarsList)

0 comments on commit 8a8525b

Please sign in to comment.