Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #281 - Use the most-recent version, not the most-used version for the crash dash #282

Merged
merged 2 commits into from Feb 28, 2017

Conversation

@chutten
Copy link
Contributor

@chutten chutten commented Feb 1, 2017

The crash dash currently displays the most-used version per channel in an
effort to maximize the crash rate denominator "kuh".

This isn't terribly helpful as, once a new release lands, we cease to really
care about the stability of the old one.

So track the release schedule using https://product-details.mozilla.org and
only use data from the most recent release.

Issue #281


This change is Reviewable

@chutten
Copy link
Contributor Author

@chutten chutten commented Feb 1, 2017

@chutten
Copy link
Contributor Author

@chutten chutten commented Feb 2, 2017

This needs some tweaking. It needs to auto-select a day from the latest version instead of waiting for usage to increase enough to match the previous version's use, and the crash plot can probably just stop truncating on the x-axis.

Copy link
Collaborator

@fbertsch fbertsch left a comment

  1. The y-axis is way below the max y-value, is this expected?

  2. The % next to each number doesn't seem very relevant anymore (sways wildly between 10^-2 and 10^4, depending on how far after the release). Maybe it's best to compare the X days after the previous release for that channel?

return (window.parseInt(major, 10) + add) + ".0"
};

var formatYYYYmmdd = function(d) {

This comment has been minimized.

@fbertsch

fbertsch Feb 7, 2017
Collaborator

Indentation?

@@ -61,6 +62,9 @@
var gData = undefined;
var gMap = {};

// When populated, this is a map activity_date -> channel -> version
var gLatestVersions = getLatestVersions();

This comment has been minimized.

@fbertsch

fbertsch Feb 7, 2017
Collaborator

With limit=10 (at least, I think that is what is causing the problem), some options for "analyzed date" aren't showing (well, they show, but they don't update the table). Check the earliest date (2016-11-08) for an example of this. Gets a "TypeError: gMap[weekAgoDate] is undefined".

This comment has been minimized.

@chutten

chutten Feb 10, 2017
Author Contributor

The first seven dates don't work as they rely on data being present a week before. I suppose I can make that safe, but it's always been that way. I've filed #284 for this.

Copy link
Contributor Author

@chutten chutten left a comment

  1. The y axis is locked so that crash spikes don't reduce the rest of the graph to a flat line near 0.

  2. I've struggled with the usefulness of the %ge stuff. It's a real pain, but if I remove them users may misunderstand the veracity of the dash's claims. As I can't guarantee that the data for multiple releases will be the same (or even present in the query results) I don't think I can use "release + x days" as a metric. (especially if a release is delayed).

This leaves me unfortunately uncertain about what to do with them.

@chutten chutten force-pushed the chutten:gh-pages branch from a65fa0d to 2800e31 Feb 10, 2017
@chutten chutten force-pushed the chutten:gh-pages branch from 2800e31 to 1572743 Feb 23, 2017
They complicate debugging and add noise to the logs.
@chutten chutten force-pushed the chutten:gh-pages branch 8 times, most recently from bd2b5e4 to 55a0ac9 Feb 23, 2017
@chutten chutten force-pushed the chutten:gh-pages branch from 55a0ac9 to b8f259b Feb 23, 2017
Copy link
Collaborator

@fbertsch fbertsch left a comment

LGTM

@chutten chutten merged commit 3cb39c0 into mozilla:gh-pages Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants