Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "No Container" copy with something else? #71

Closed
groovecoder opened this issue Jan 10, 2017 · 7 comments
Closed

Replace "No Container" copy with something else? #71

groovecoder opened this issue Jan 10, 2017 · 7 comments
Assignees
Milestone

Comments

@groovecoder
Copy link
Member

When a user right-clicks a link and chooses "Open Link in New Container Tab >", they see a "No Container" option.

no-container-tab

Do we want to keep this copy?

@TanviHacks
Copy link

This happens when the user right clicks a link while in a non-default container tab.

@johngruen

@jonathanKingston
Copy link
Contributor

Can we hide the "no container" and the <hr/> and have a "None" or "Default" container. The URL bar could reflect that too.

As a separate idea I would like "Default" to show the same doorhanger for forms as if they are http forms. The idea being trying to persuade users never to share PII (Personally identifiable information) with sites unless they pick a container.

@bakulf
Copy link
Collaborator

bakulf commented Jan 11, 2017

I use this feature more or less daily: I just segregate gmail. But when I open a bugzilla link, I want it in the 'default' container.

@johngruen johngruen self-assigned this Jan 19, 2017
@johngruen johngruen added this to the MVP milestone Jan 19, 2017
@TanviHacks
Copy link

If we can't think of the right copy, we could in the worst case add back "Open Link in New Tab"

@bakulf
Copy link
Collaborator

bakulf commented Jan 31, 2017

Note that the context menu (as the file->new container tab menu) now is fully created by the addon.
We can change it easily.

@groovecoder
Copy link
Member Author

@johngruen ping

@pdehaan
Copy link
Collaborator

pdehaan commented Feb 17, 2017

@jgruen says "wontfix"

@pdehaan pdehaan closed this as completed Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants