New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Test Pilot user database. #1034

Closed
ckprice opened this Issue Jul 7, 2016 · 6 comments

Comments

Projects
5 participants
@ckprice
Contributor

ckprice commented Jul 7, 2016

Drop email addresses from the database. This data is in exact target now and we don't need a copy of it.

@lmorchard

This comment has been minimized.

Show comment
Hide comment
@lmorchard

lmorchard Jul 11, 2016

Member

Something that occurred to me: We probably want to keep the actual DB tables, but delete most of the records. That is, all users without the is_staff and/or is_superuser flags. Until we get to using flat files (#988), we still need admin logins to access the admin pages.

Member

lmorchard commented Jul 11, 2016

Something that occurred to me: We probably want to keep the actual DB tables, but delete most of the records. That is, all users without the is_staff and/or is_superuser flags. Until we get to using flat files (#988), we still need admin logins to access the admin pages.

@lmorchard

This comment has been minimized.

Show comment
Hide comment
@lmorchard

lmorchard Jul 11, 2016

Member

See also: #1056

Member

lmorchard commented Jul 11, 2016

See also: #1056

@lmorchard

This comment has been minimized.

Show comment
Hide comment
@lmorchard

lmorchard Jul 13, 2016

Member

Collapsing #1056 & #1046 into this issue as things to keep in mind when we delete data:

  • Retain contributor accounts & profiles (i.e. make sure is_staff=True)
  • Retain admin accounts (i.e. is_superuser=True)
  • Ensure admin accounts can be logged into at /admin/ by setting passwords

We need to keep the actual user database around, but we can delete all records where is_superuser=false AND is_staff=false and clean up all data not related to core staff

Member

lmorchard commented Jul 13, 2016

Collapsing #1056 & #1046 into this issue as things to keep in mind when we delete data:

  • Retain contributor accounts & profiles (i.e. make sure is_staff=True)
  • Retain admin accounts (i.e. is_superuser=True)
  • Ensure admin accounts can be logged into at /admin/ by setting passwords

We need to keep the actual user database around, but we can delete all records where is_superuser=false AND is_staff=false and clean up all data not related to core staff

@wresuolc

This comment has been minimized.

Show comment
Hide comment
@wresuolc

wresuolc Jul 18, 2016

Contributor

Marking as blocked just to keep us from landing this yet. Next sprint please.

Contributor

wresuolc commented Jul 18, 2016

Marking as blocked just to keep us from landing this yet. Next sprint please.

@ckprice

This comment has been minimized.

Show comment
Hide comment
@ckprice

ckprice Jul 29, 2016

Contributor

I'm going to take this off this milestone as it doesn't block TXP-7.

Contributor

ckprice commented Jul 29, 2016

I'm going to take this off this milestone as it doesn't block TXP-7.

@ckprice ckprice modified the milestones: TXP-0: Code Quality, Bug Fixes, Technical Debt, TXP-7 Remove Firefox Accounts & Replace with Email Collection Jul 29, 2016

@johngruen johngruen added this to the TXP-30 Remove Django milestone Aug 15, 2016

@lmorchard lmorchard self-assigned this Aug 23, 2016

@lmorchard lmorchard removed the blocked label Aug 23, 2016

@lmorchard

This comment has been minimized.

Show comment
Hide comment
@lmorchard

lmorchard Aug 23, 2016

Member

So, I think this can be unblocked now, and taken care of with some SQL run on stage / prod with the next deployment. That, or I can write a Django DB migration that takes care of it. I'm going to poke around a bit on my local machine and see if I can't come up with something solid before tomorrow EoD.

Basically, I think we want to wipe out all accounts & profiles & email address records - except for users with /admin/ access and users included as contributors on experiments.

Member

lmorchard commented Aug 23, 2016

So, I think this can be unblocked now, and taken care of with some SQL run on stage / prod with the next deployment. That, or I can write a Django DB migration that takes care of it. I'm going to poke around a bit on my local machine and see if I can't come up with something solid before tomorrow EoD.

Basically, I think we want to wipe out all accounts & profiles & email address records - except for users with /admin/ access and users included as contributors on experiments.

lmorchard added a commit to lmorchard/testpilot that referenced this issue Aug 24, 2016

Delete old user accounts from the database
- Ensure contributors on experiments are counted as staff

- Delete all user non-staff user accounts

- Drop old tables used by the old Firefox Accounts integration

Fixes #1034

lmorchard added a commit to lmorchard/testpilot that referenced this issue Aug 25, 2016

Delete old user accounts from the database
- Ensure contributors on experiments are counted as staff

- Delete all user non-staff user accounts

- Drop old tables used by the old Firefox Accounts integration

- Tests for account deletion

Fixes #1034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment