New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Firefox Accounts #1035

Closed
ckprice opened this Issue Jul 7, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@ckprice
Contributor

ckprice commented Jul 7, 2016

  • Remove FxA connections.
  • Remove django-allauth from project (which enables #1034).
  • Remove user email and "Logout" from [...] menu.
  • Remove Firefox Accounts oauth credentials.
@lmorchard

This comment has been minimized.

Show comment
Hide comment
@lmorchard

lmorchard Jul 7, 2016

Member

For what it's worth, this bug looked "too large" to me, so I split it up a bit and added some more issues - #1040, #1041, #1042, #1043. Will probably do some more tweaking as I think through what else is touched by FxA and user accounts, because there are some weird corners

Member

lmorchard commented Jul 7, 2016

For what it's worth, this bug looked "too large" to me, so I split it up a bit and added some more issues - #1040, #1041, #1042, #1043. Will probably do some more tweaking as I think through what else is touched by FxA and user accounts, because there are some weird corners

@lmorchard lmorchard changed the title from Remove Firefox Accounts & Replace with Email Collection to Remove Firefox Accounts Jul 7, 2016

@6a68

This comment has been minimized.

Show comment
Hide comment
@6a68

6a68 Jul 7, 2016

Member

Do we also want to ask the FxA team to deactivate our oauth credentials? Not sure if this should be a checkbox or a separate coordination TODO.

Member

6a68 commented Jul 7, 2016

Do we also want to ask the FxA team to deactivate our oauth credentials? Not sure if this should be a checkbox or a separate coordination TODO.

@lmorchard

This comment has been minimized.

Show comment
Hide comment
@lmorchard

lmorchard Jul 12, 2016

Member

Seems like #1047 is covering most of the visible & usable aspects of this issue. So, I'm considering this one as the final cleanup steps - e.g. remove django-allauth from the project, delete the contents of the socialaccounts tables, clean up anything else lingering related to FxA short of wiping the users (#1034)

Member

lmorchard commented Jul 12, 2016

Seems like #1047 is covering most of the visible & usable aspects of this issue. So, I'm considering this one as the final cleanup steps - e.g. remove django-allauth from the project, delete the contents of the socialaccounts tables, clean up anything else lingering related to FxA short of wiping the users (#1034)

@lmorchard

This comment has been minimized.

Show comment
Hide comment
@lmorchard

lmorchard Jul 13, 2016

Member

Something occurs to me: Once #1065 is merged, we won't actually have Firefox Accounts wired up on the server side anymore. So, this issue could possibly lag behind the deployment of that stuff along with the user database cleanup.

Member

lmorchard commented Jul 13, 2016

Something occurs to me: Once #1065 is merged, we won't actually have Firefox Accounts wired up on the server side anymore. So, this issue could possibly lag behind the deployment of that stuff along with the user database cleanup.

lmorchard added a commit to lmorchard/testpilot that referenced this issue Jul 15, 2016

Remove Firefox Accounts and related code
- Drop django-allauth, oauthlib, and python3-openid from
  requirements.txt

- Remove FxA and allauth related things from testpilot/settings.py,
  including Basket API keys

- Remove more FxA related modules from the testpilot.users app

- Clean up unused Jinja templates

- user_id no longer needed in frontend view

- Remove & clean up tests

Fixes #1035

lmorchard added a commit to lmorchard/testpilot that referenced this issue Jul 15, 2016

Remove Firefox Accounts and related code
- Drop django-allauth, oauthlib, and python3-openid from
  requirements.txt

- Remove FxA and allauth related things from testpilot/settings.py,
  including Basket API keys

- Remove more FxA related modules from the testpilot.users app

- Clean up unused Jinja templates

- user_id no longer needed in frontend view

- Remove & clean up tests

Fixes #1035

@lmorchard lmorchard self-assigned this Jul 15, 2016

lmorchard added a commit to lmorchard/testpilot that referenced this issue Jul 15, 2016

Remove Firefox Accounts and related code
- Drop django-allauth, oauthlib, and python3-openid from
  requirements.txt

- Remove FxA and allauth related things from testpilot/settings.py,
  including Basket API keys

- Remove more FxA related modules from the testpilot.users app

- Clean up unused Jinja templates

- user_id no longer needed in frontend view

- Remove & clean up tests

Fixes #1035

lmorchard added a commit to lmorchard/testpilot that referenced this issue Jul 15, 2016

Remove Firefox Accounts and related code
- Drop django-allauth, oauthlib, and python3-openid from
  requirements.txt

- Remove FxA and allauth related things from testpilot/settings.py,
  including Basket API keys

- Remove more FxA related modules from the testpilot.users app

- Clean up unused Jinja templates

- user_id no longer needed in frontend view

- Remove & clean up tests

Fixes #1035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment