Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Add Closure Compiler to our pipeline #2445

Closed
fzzzy opened this issue May 17, 2017 · 4 comments
Closed

Add Closure Compiler to our pipeline #2445

fzzzy opened this issue May 17, 2017 · 4 comments

Comments

@fzzzy
Copy link
Contributor

fzzzy commented May 17, 2017

(edit: This bug was originally about prepack, but it doesn't work and Closure Compiler does, so this bug is now about that.)

https://prepack.io

@fzzzy
Copy link
Contributor Author

fzzzy commented Aug 24, 2017

Preact is too alpha. It has an exception when I try to run it on a mashed-together app.js and vendor.js bundle.

I also tried closure compiler, and it also has an error. I may be able to fix it by upgrading react. Testing...

@fzzzy
Copy link
Contributor Author

fzzzy commented Aug 24, 2017

Upgrading react fixed the problems with using closure compiler on the bundle. It cuts the app+vendor bundle size in half, from 2.7 meg to 1.3 meg.

@fzzzy fzzzy changed the title Try adding prepack to our pipeline Add Closure Compiler to our pipeline Aug 24, 2017
@fzzzy
Copy link
Contributor Author

fzzzy commented Aug 24, 2017

Here's the command line I am using, for future reference:

java -jar ../compiler-latest/closure-compiler-v20170806.jar --js frontend/build/static/app/app.js --js_output_file frontend/build/static/app/app-cc.js

@fzzzy fzzzy self-assigned this Aug 31, 2017
@fzzzy
Copy link
Contributor Author

fzzzy commented Sep 5, 2017

Les was able to switch to webpack, which also does tree-shaking, so we don't need this any more. The webpack branch shrinks our bundle sizes.

@fzzzy fzzzy closed this as completed Sep 5, 2017
@ghost ghost added this to the Sprint 31 milestone Sep 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant