New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Remove content from old experiments #2657

Closed
flodolo opened this Issue Jul 25, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@flodolo
Collaborator

flodolo commented Jul 25, 2017

A contributor starting to localizing the website correctly noted that there's a ton of obsolete content in experiments.ftl

Example: AS, cliqz, nomore404, paheshot, etc.

Why can't we get rid of this content?

CC @rprys

@fzzzy

This comment has been minimized.

Show comment
Hide comment
@fzzzy

fzzzy Jul 26, 2017

Collaborator

We still show all the old experiment content, under "view past experiments". It seems fine if new languages don't want to do the work to localize old experiments though.

Collaborator

fzzzy commented Jul 26, 2017

We still show all the old experiment content, under "view past experiments". It seems fine if new languages don't want to do the work to localize old experiments though.

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Jul 26, 2017

Collaborator

Good point, I completely missed that we still have that content. Is the plan to keep them on the website for the time being?

Collaborator

flodolo commented Jul 26, 2017

Good point, I completely missed that we still have that content. Is the plan to keep them on the website for the time being?

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Jul 26, 2017

Collaborator

Correction: we still have the experiments, but there's a lot of content not available anymore (tour, privacy notes).
https://testpilot.firefox.com/experiments/activity-stream

So, there's a lot of content that could be removed when an experiment retires.

Collaborator

flodolo commented Jul 26, 2017

Correction: we still have the experiments, but there's a lot of content not available anymore (tour, privacy notes).
https://testpilot.firefox.com/experiments/activity-stream

So, there's a lot of content that could be removed when an experiment retires.

@fzzzy

This comment has been minimized.

Show comment
Hide comment
@fzzzy

fzzzy Jul 26, 2017

Collaborator

Good call on removing content that actually isn't used any more. Let's do this.

Collaborator

fzzzy commented Jul 26, 2017

Good call on removing content that actually isn't used any more. Let's do this.

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Oct 5, 2017

Collaborator

Any chance of getting resources on this? I keep getting this question from locales that want to localize Test Pilot.

Collaborator

flodolo commented Oct 5, 2017

Any chance of getting resources on this? I keep getting this question from locales that want to localize Test Pilot.

@fzzzy fzzzy self-assigned this Oct 10, 2017

@fzzzy

This comment has been minimized.

Show comment
Hide comment
@fzzzy

fzzzy Oct 10, 2017

Collaborator

I'll do this now.

Collaborator

fzzzy commented Oct 10, 2017

I'll do this now.

fzzzy added a commit to fzzzy/testpilot that referenced this issue Oct 19, 2017

Fix mozilla#2657 Remove ftl strings from old experiments so localizer…
…s don't have to translate strings which will never be shown anywhere.

Once an experiment has graduated, the following strings should be
removed for the experiment:

- measurements
- prefeedbackcopy
- toursteps
- eolwarning

@lmorchard lmorchard closed this in 9957360 Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment