New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1711 newsletter footer ga #2931

Merged
merged 4 commits into from Oct 12, 2017

Conversation

Projects
None yet
3 participants
@meandavejustice
Member

meandavejustice commented Oct 11, 2017

fixes #1711

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 11, 2017

Codecov Report

Merging #2931 into master will increase coverage by 12.93%.
The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2931       +/-   ##
===========================================
+ Coverage   81.92%   94.86%   +12.93%     
===========================================
  Files         103       86       -17     
  Lines        2683     2277      -406     
===========================================
- Hits         2198     2160       -38     
+ Misses        485      117      -368
Impacted Files Coverage Δ
...ntend/src/app/components/NewsletterFooter/index.js 100% <100%> (ø)
...ntend/src/app/components/NewsletterFooter/tests.js 94.44% <90.9%> (ø)
frontend/test/app/containers/RestartPage-test.js 100% <0%> (ø) ⬆️
frontend/src/app/reducers/addon.js
frontend/src/app/actions/localizations.js
frontend/src/app/lib/addon.js
...end/src/app/containers/UpgradeWarningPage/tests.js
frontend/src/app/reducers/varianttests.js
...end/src/app/containers/UpgradeWarningPage/index.js
frontend/src/app/selectors/addon.js
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d829ba...55132bf. Read the comment docs.

codecov-io commented Oct 11, 2017

Codecov Report

Merging #2931 into master will increase coverage by 12.93%.
The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2931       +/-   ##
===========================================
+ Coverage   81.92%   94.86%   +12.93%     
===========================================
  Files         103       86       -17     
  Lines        2683     2277      -406     
===========================================
- Hits         2198     2160       -38     
+ Misses        485      117      -368
Impacted Files Coverage Δ
...ntend/src/app/components/NewsletterFooter/index.js 100% <100%> (ø)
...ntend/src/app/components/NewsletterFooter/tests.js 94.44% <90.9%> (ø)
frontend/test/app/containers/RestartPage-test.js 100% <0%> (ø) ⬆️
frontend/src/app/reducers/addon.js
frontend/src/app/actions/localizations.js
frontend/src/app/lib/addon.js
...end/src/app/containers/UpgradeWarningPage/tests.js
frontend/src/app/reducers/varianttests.js
...end/src/app/containers/UpgradeWarningPage/index.js
frontend/src/app/selectors/addon.js
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d829ba...55132bf. Read the comment docs.

@lmorchard lmorchard merged commit 77c3321 into mozilla:master Oct 12, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@meandavejustice meandavejustice deleted the meandavejustice:1711-newsletter-footer-ga branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment