Make "menu appears" transition consistent. #1634

Closed
flukeout opened this Issue Jan 16, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@flukeout
Contributor

flukeout commented Jan 16, 2017

The publish menu and the gear menu have a different style of appearing. One fades in while the other appears suddenly. Let's make the Publish dialog appear instantly like the gear menu.

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jan 24, 2017

Member

The fade-in on the Publish dialog happens here:

Member

humphd commented Jan 24, 2017

The fade-in on the Publish dialog happens here:

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jan 26, 2017

Member

I'll work on this. I'm going to fix it and write it up as an example.

Member

humphd commented Jan 26, 2017

I'll work on this. I'm going to fix it and write it up as an example.

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jan 26, 2017

Member

Blog post is up at: http://blog.humphd.org/fixing-a-bug-in-mozilla-thimble/. I'll do the actual fix later with my students in class, to show them.

Member

humphd commented Jan 26, 2017

Blog post is up at: http://blog.humphd.org/fixing-a-bug-in-mozilla-thimble/. I'll do the actual fix later with my students in class, to show them.

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Feb 2, 2017

Member

I have the fix for this, but I want to show my students how to do a rebase/squash using it as an example. I'll do that on Tues.

Member

humphd commented Feb 2, 2017

I have the fix for this, but I want to show my students how to do a rebase/squash using it as an example. I'll do that on Tues.

Th30 pushed a commit to Th30/thimble.mozilla.org that referenced this issue Feb 3, 2017

@Th30

This comment has been minimized.

Show comment
Hide comment
@Th30

Th30 Mar 10, 2017

Contributor

I'll push a fix for this tonight @humphd

Contributor

Th30 commented Mar 10, 2017

I'll push a fix for this tonight @humphd

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Mar 11, 2017

Member

Awesome, thanks!

Member

humphd commented Mar 11, 2017

Awesome, thanks!

Th30 added a commit to Th30/thimble.mozilla.org that referenced this issue Mar 11, 2017

@flukeout flukeout closed this in c1b5581 Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment