Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make items in user dropdown menu easier to click. #1635
The items in the dropdown menus only work if you click the text of the item, and not the entire length and height of the highlighted item when you hover.
This is because each item is a...
...and the padding around the item is applied to the
To fix these we either...
As far as contributing, the first step would be to get your dev environment up and running. Follow the steps in the readme here... https://github.com/mozilla/thimble.mozilla.org
Then, you're free to get rolling and ask us for help if you get stuck.
No coding conventions document yet since we don't specifically follow a style guide. @raygervais, for now, I would try to follow the conventions that you see in the file you are working with. If there are any issues with coding conventions, we will point them out in your PR so I wouldn't worry about them at the moment.
@gideonthomas thank you for the advice. @flukeout, I've attached an example of your second suggested option to fix this issue, and believe it is the most optimal way as well. You'll see that I used Firefox's highlight tool to ensure that it would not affect any other element on the page. In doing so, I also reduced surrounding
If you are satisfied with this, I'd be happy to start a PR right away. Furthermore, the height and width made no difference here, so I will not include in the final commit.
added a commit
Feb 3, 2017
referenced this issue
Feb 3, 2017
Overall, this is great. Here are some thoughts.
You can remove the height from the
That way you can drop the
Give that a try and please go ahead with starting the PR. Looking forward.