New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Publish popup title when project is Live #1918

Closed
flukeout opened this Issue Mar 27, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@flukeout
Contributor

flukeout commented Mar 27, 2017

Currently, the popup title always says "Publish your Project", even if it is already published...

image

Let's change it to "Your Project is Online" when the project is published.

@rkgupta21

This comment has been minimized.

Contributor

rkgupta21 commented Mar 27, 2017

I would like to work on this bug.

@flukeout

This comment has been minimized.

Contributor

flukeout commented Mar 27, 2017

👍 Great, go ahead!

@rkgupta21

This comment has been minimized.

Contributor

rkgupta21 commented Apr 4, 2017

I found the file where header value is used. Its in publish.html

<h1>{{ gettext("publishHeader") }}</h1>

As per my understanding i need to check whether the project is published or not and if it is published then change the publish header value to the required text "Your Project is Online". Where do i need to implement the code to make this change? Is it gonna be in publish.html file ?

@humphd

This comment has been minimized.

Member

humphd commented Apr 6, 2017

@flukeout or @gideonthomas, can you give some guidance to @rkgupta21 on how to get started with this please?

@gideonthomas

This comment has been minimized.

Member

gideonthomas commented Apr 6, 2017

sure!

Your change needs to happen in the file that you mentioned. You're gonna need to write a check something like this: https://github.com/mozilla/thimble.mozilla.org/blob/master/views/editor/projects.html#L39-L42 to determine what needs to be shown in the h1 tag. As far as localization is concerned, refer to https://github.com/mozilla/thimble.mozilla.org/wiki/Localization#strings and https://github.com/mozilla/thimble.mozilla.org/wiki/Localization#server-side-localization to add your new string.

Let us know if you have any questions @rkgupta21

@rkgupta21

This comment has been minimized.

Contributor

rkgupta21 commented Apr 17, 2017

@gideonthomas

I've added {% if project.publish_url %} in publish.html.
screen shot 2017-04-16 at 9 28 39 pm

But i noticed that it is always going in the else condition, and always displaying Your Project is Online
screen shot 2017-04-16 at 9 26 46 pm

I think that publish.html doesnt have access to project.publish_url

Do I need to import anything?

@flukeout

This comment has been minimized.

Contributor

flukeout commented Apr 20, 2017

@rkgupta21 can you open a pull request with your changes so we can look & work on it there? It will be easier if we have access to your code changes - thank you!

@marcobeltempo

This comment has been minimized.

Contributor

marcobeltempo commented Sep 28, 2017

Hi @flukeout , I'm currently a student at Seneca college learning open source, and I was hoping to work on this bug for my course. If no one else is currently working on it, I'd like to give it a try.

@flukeout

This comment has been minimized.

Contributor

flukeout commented Sep 28, 2017

Hi @marcobeltempo - I think it's fair if you start work on this. @rkgupta21 has submitted a pull request here (#2022) but it looks like has has stopped working on it. Please review the notes and comments there as they might be helpful to you.

Cheers!

@flukeout flukeout assigned flukeout and unassigned flukeout Sep 28, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 8, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 8, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 8, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 8, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 13, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 13, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 13, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 13, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 13, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 13, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 13, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 13, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

marcobeltempo added a commit to marcobeltempo/thimble.mozilla.org that referenced this issue Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment