New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github icon on Get Involved page is black in Firefox. Should be white. #2536

Closed
flukeout opened this Issue Oct 20, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@flukeout
Contributor

flukeout commented Oct 20, 2017

On https://thimble.mozilla.org/en-US/get-involved/ the Github icon on the button is black, but should be white...

This is happening in Firefox only, and has happened to other SVGs on the site in the past. I'm pretty sure if we run the SVG through https://jakearchibald.github.io/svgomg/ it starts to work correctly after, so that's what I'd recommend trying here.

@marcobeltempo

This comment has been minimized.

Contributor

marcobeltempo commented Oct 20, 2017

Hi @flukeout I would like to take this one on

@gideonthomas

This comment has been minimized.

Member

gideonthomas commented Oct 20, 2017

Assigning to you @marcobeltempo

@ghost

This comment has been minimized.

ghost commented Oct 28, 2017

We can use font awesome for white icon.

<i class="fa fa-github" aria-hidden="true"></i>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment