Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining uses of Courier to Courier New #2554

Open
humphd opened this Issue Nov 13, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@humphd
Copy link
Member

humphd commented Nov 13, 2017

From mozilla/brackets#892, we should do a quick audit to make sure that other extensions or JS files that touch fonts also make this same change. cc @JosefJezek

@marcobeltempo

This comment has been minimized.

Copy link
Contributor

marcobeltempo commented Nov 16, 2017

@humphd this was the only instance I could find

font-family: Consolas, Inconsolata, 'Lucida Console', Courier, monospace, fixed;

@gideonthomas

This comment has been minimized.

Copy link
Member

gideonthomas commented Nov 19, 2017

@marcobeltempo, I think you'll want to check in the brackets repo as well

@marcobeltempo

This comment has been minimized.

Copy link
Contributor

marcobeltempo commented Nov 19, 2017

@gideonthomas should I open a separate issue in brackets?

@humphd

This comment has been minimized.

Copy link
Member Author

humphd commented Nov 20, 2017

@marcobeltempo no, you can just do a PR in the Brackets repo. We tend to do issues here, since they are all conceptually related to Thimble. It's confusing, I know.

@marcobeltempo

This comment has been minimized.

Copy link
Contributor

marcobeltempo commented Nov 24, 2017

@humphd I would like to take on this issue.

In addition to these files you've highlighted below

/src/extensions/default/bramble/stylesheets/consoleTheme.less:    font-family: 'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', Courier, monospace, fixed;
/src/extensions/default/bramble/stylesheets/consoleTheme.less:    font-family: 'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', Courier, monospace, fixed;
/src/extensions/extra/JavaScriptCodeHints-Browser/styles/brackets-js-hints.css:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
/src/extensions/extra/JavaScriptCodeHints-Browser/styles/brackets-js-hints.css:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
/src/extensions/extra/JavaScriptCodeHints-Browser/styles/brackets-js-hints.css:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
/src/extensions/extra/JavaScriptCodeHints-Browser/styles/brackets-js-hints.css:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, fixed;
/src/view/ViewCommandHandlers.js:    var DEFAULT_FONT_FAMILY = "'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', Courier, monospace, fixed";

Would the changes have to be applied to the following files as well?

/src/extensions/extra/MDNDocs/MDNDocs.less Line 33:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;

/src/extensions/extra/MDNDocs/MDNDocs.less Line 49:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;

/src/extensions/extra/WebPlatformDocs/WebPlatformDocs.less Line 33:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace,   fixed;

/src/extensions/extra/WebPlatformDocs/WebPlatformDocs.less Line 49:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;

/src/extensions/extra/PDFView/thirdparty/pdfjs/web/viewer.css Line 1784: font-family: courier;
@humphd

This comment has been minimized.

Copy link
Member Author

humphd commented Nov 24, 2017

The extra extensions you list aren't ones we're using for much longer (first two), and third one we can't modify directly. With the third one, you can make changes in an _overrides.css file that's located in that extension's files and use !important;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.