New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pref toggle for enabling/disabling slowparse and UI suggestions #2580

Open
humphd opened this Issue Dec 15, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@humphd
Member

humphd commented Dec 15, 2017

I think we need to give people a way to disable the slowparse UI, since it's a pretty big change, and if you don't want it, it will be annoying. I think most people will want it, but let's just preempt the fact that not everyone will.

I looked at our current toggle preferences to see if we could just reuse one of them, but we don't really have anything like this. We might want to add a general one for all the various kinds of inline help we offer (code suggestions, for example).

NOTE: if we do this, we'll need to make sure we add a shim to Thimble's bramble API for the change to the service worker code in Brackets for the new API.

@marcobeltempo

This comment has been minimized.

Contributor

marcobeltempo commented Dec 16, 2017

@flukeout I was reading over #2575 and love the addition of the inline slowparse.
I am interested in implementing a toggle feature to go with it.

@humphd Were you thinking about having a main inline toggle + each individual toggle or just the main one?

Is there a way to test https://mozillathimblelivepreview.net/bramble/slowparse/dist/hosted.html
locally?

@humphd

This comment has been minimized.

Member

humphd commented Dec 16, 2017

@marcobeltempo I've assigned this to you. Can you do a few things?

  1. Can you help test the slowparse stuff as @flukeout discusses in #2575 (comment)? Try and see if you can break it, find bugs, etc.

  2. Work on this pref. Doing this will be a multi-part operation, some in Thimble and some in Brackets. You should begin with the Brackets stuff. Here's a rough outline:

Ask me/Luke any questions you might have, and we'll help you.

@marcobeltempo

This comment has been minimized.

Contributor

marcobeltempo commented Dec 16, 2017

@humphd Thank you for the detailed guidance. I will start tackling this and update my status on each step as I go

@marcobeltempo

This comment has been minimized.

Contributor

marcobeltempo commented Dec 22, 2017

Just a quick status update @humphd
I've pushed my most recent changes to an issue branch on my forked repo.
You can see the commit here: /marcobeltempo/brackets/commit/c8d2bd4

To-do

  • Update README
  • Add getAllowHints() to bramble API
  • Add enableHints() to bramble API
  • Add disableHints() to bramble API
  • Add code to brackets /src/bramble/client/main.js
  • Implement response to enable/disable commands in /src/extensions/default/bramble/lib/RemoteCommandHandler.j
  • Shim Bramble API in thimble /public/editor/scripts/bramble-shim.js
  • Wire up UI to call Bramble API
@marcobeltempo

This comment has been minimized.

Contributor

marcobeltempo commented Jan 3, 2018

@humphd I've added the code to shim Bramble as well as the UI toggle. I just need some guidance in connecting with @flukeout code

@humphd

This comment has been minimized.

Member

humphd commented Jan 4, 2018

I need to sync up with @flukeout to see what we're doing with the slowparse feature--there's no PR for it yet. Probably the easiest thing will be to do something via a preference on the Brackets side, which I can talk you through. Let me hear from Luke first.

@gideonthomas

This comment has been minimized.

Member

gideonthomas commented Jan 8, 2018

@humphd the PR is here: mozilla/brackets#876. I think I was supposed to review it but it fell off my radar. I can review it this week, but feel free to get to it before I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment