New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Alt + K tag code hints behavior #591

Open
flukeout opened this Issue Jun 22, 2015 · 3 comments

Comments

Projects
None yet
6 participants
@flukeout
Contributor

flukeout commented Jun 22, 2015

Steps to reproduce

It should either close or do nothing. I think that it should just close.

@flukeout flukeout added the bug label Jun 22, 2015

@JordanTheriault

This comment has been minimized.

Show comment
Hide comment
@JordanTheriault

JordanTheriault Jun 23, 2015

Contributor

I think this can be solved upstream, as the code to open/close the hints were written by a contributor there (modified from WebPlatformDocs).

Contributor

JordanTheriault commented Jun 23, 2015

I think this can be solved upstream, as the code to open/close the hints were written by a contributor there (modified from WebPlatformDocs).

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jul 22, 2015

Member

It's a bug in Brackets related to there not being focus set in the inline editor. I'm pretty sure it's filed upstream, it's known already.

Member

humphd commented Jul 22, 2015

It's a bug in Brackets related to there not being focus set in the inline editor. I'm pretty sure it's filed upstream, it's known already.

@flukeout flukeout referenced this issue Jan 5, 2016

Closed

Triage issues #1317

@gideonthomas gideonthomas added the P3 label Jan 7, 2016

@gideonthomas gideonthomas removed the P3 label Oct 31, 2016

@flukeout flukeout changed the title from Unexpected Command + K tag code hints behavior to Unexpected Alt + K tag code hints behavior Mar 2, 2017

@sdalmeida

This comment has been minimized.

Show comment
Hide comment
@sdalmeida

sdalmeida Apr 5, 2017

Contributor

Hi @flukeout,
Whats the status of this bug? Looking at the code, I found that this what's causing the bug:

https://github.com/mozilla/brackets/blob/master/src/editor/EditorManager.js#L260

Because it doesn't know that the widget is open, it will force close before opening.
Is this still something that needs to be fixed?
Let me know :)

The bug still exists in the current build:
ezgif com-optimize 2

Contributor

sdalmeida commented Apr 5, 2017

Hi @flukeout,
Whats the status of this bug? Looking at the code, I found that this what's causing the bug:

https://github.com/mozilla/brackets/blob/master/src/editor/EditorManager.js#L260

Because it doesn't know that the widget is open, it will force close before opening.
Is this still something that needs to be fixed?
Let me know :)

The bug still exists in the current build:
ezgif com-optimize 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment