Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Determine whether to add a project/ root dir to export zip #889
This is something @Pomax raised, and I've been pondering it ever since. When you export your project as a
But consider the case of someone exporting a project, emailing it to a friend, and then that friend dragging it into Thimble. It will work, but they will end up with a
Hello I am a user =)
Being able to drag my code into Thimble for immediate editing and then getting it back out with an export is actually really nice. Rather than close, I'd say "let's go with
It's a nice feature to have, an interesting feature to work on for contributors, and opens up thimble as a roundtripping workflow tool that it currently simple cannot be used for.
The code for this is in here https://github.com/mozilla/brackets/blob/master/src/filesystem/impls/filer/ArchiveUtils.js. It would be pretty easy to change.
@Riyuzakii we have code that allows a user to a) download a
The code that does this automatically takes your files, and prepends a
We do this because it's considered good form to always have a zip file expand into a directory vs. into the current directory (it makes it easier to delete or move the files afterward).
In the case that you export a
When we do the extraction, we first begin by scanning all the files/folders in the
Right here, we could do a bit more work to look for files that begin with
Let me know if this makes sense or not, and if you have more questions. You can also chat with the developers by using Mozilla's Thimble channel on their Mattermost server, see https://github.com/mozilla/thimble.mozilla.org#contact-us.