New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow project export to .zip file when not logged in #981

Closed
humphd opened this Issue Aug 30, 2015 · 28 comments

Comments

Projects
7 participants
@humphd
Member

humphd commented Aug 30, 2015

We have the Export project... menu item hiding in the authenticated drop-down menu. We should allow you to get a .zip file of your project without having to be logged in.

@gideonthomas gideonthomas added UX UI labels Sep 1, 2015

@flukeout flukeout self-assigned this Nov 13, 2015

@humphd humphd added this to the Final stride milestone Nov 13, 2015

@gideonthomas gideonthomas added Good First Bug P3 and removed UI labels Jan 6, 2016

@gideonthomas gideonthomas removed this from the Final stride milestone Jan 19, 2016

@gideonthomas gideonthomas added UI and removed P3 labels Oct 31, 2016

@ryanwarsaw ryanwarsaw self-assigned this Dec 3, 2016

@ryanwarsaw ryanwarsaw removed their assignment Dec 18, 2016

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jan 24, 2017

Member

Fixing this requires us to move the menu option for export out of the logged in user menu (or add a second menu option). Right now it looks like this:

screen shot 2017-01-24 at 1 12 22 pm

Should we put a new button beside the '+' in the file tree that means "Download"? @flukeout, can you weigh in?

The code in Bramble that does the zip stuff is here https://github.com/mozilla/brackets/blob/master/src/extensions/default/bramble/lib/RemoteCommandHandler.js#L146-L148 (see ArchiveUtils https://github.com/mozilla/brackets/blob/master/src/filesystem/impls/filer/ArchiveUtils.js).

In Thimble you trigger it like this:

$("#export-project-zip").click(function() {
bramble.export();

Member

humphd commented Jan 24, 2017

Fixing this requires us to move the menu option for export out of the logged in user menu (or add a second menu option). Right now it looks like this:

screen shot 2017-01-24 at 1 12 22 pm

Should we put a new button beside the '+' in the file tree that means "Download"? @flukeout, can you weigh in?

The code in Bramble that does the zip stuff is here https://github.com/mozilla/brackets/blob/master/src/extensions/default/bramble/lib/RemoteCommandHandler.js#L146-L148 (see ArchiveUtils https://github.com/mozilla/brackets/blob/master/src/filesystem/impls/filer/ArchiveUtils.js).

In Thimble you trigger it like this:

$("#export-project-zip").click(function() {
bramble.export();

@sdalmeida

This comment has been minimized.

Show comment
Hide comment
@sdalmeida

sdalmeida Jan 26, 2017

Contributor

I'd like to work on this feature (Since it's been opened for almost 2 years).
Looks like @flukeout is assigned to it already. Are you still working on it or should I implement it?
Thanks 👍

Contributor

sdalmeida commented Jan 26, 2017

I'd like to work on this feature (Since it's been opened for almost 2 years).
Looks like @flukeout is assigned to it already. Are you still working on it or should I implement it?
Thanks 👍

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jan 26, 2017

Member

Go for it, @Simon66

Member

humphd commented Jan 26, 2017

Go for it, @Simon66

@sdalmeida

This comment has been minimized.

Show comment
Hide comment
@sdalmeida

sdalmeida Jan 28, 2017

Contributor

I thought of 3 possibilities where we can have the export button:

  1. When a "guest" (Not logged in user) starts a new project, this is how they can export the project
    capture1
  2. We can add an export button here but I'm not too sure if this is a good spot (If they minimize the side bar, the export button is now hidden).
    capture2
  3. We could also have the Export button here
    capture3

I prefer option 1 since it follows the same layout as a logged in user. This is good practice since a "guest" will eventually register and they should already be familiar with the layout.

Which option would be best? Is there another place you can think of?
Also, as for icons, is there a preferred place where I can get more icons? Depending on which option we go with, we will need more icons.

Contributor

sdalmeida commented Jan 28, 2017

I thought of 3 possibilities where we can have the export button:

  1. When a "guest" (Not logged in user) starts a new project, this is how they can export the project
    capture1
  2. We can add an export button here but I'm not too sure if this is a good spot (If they minimize the side bar, the export button is now hidden).
    capture2
  3. We could also have the Export button here
    capture3

I prefer option 1 since it follows the same layout as a logged in user. This is good practice since a "guest" will eventually register and they should already be familiar with the layout.

Which option would be best? Is there another place you can think of?
Also, as for icons, is there a preferred place where I can get more icons? Depending on which option we go with, we will need more icons.

@Pomax

This comment has been minimized.

Show comment
Hide comment
@Pomax

Pomax Jan 28, 2017

Contributor

It feels like exporting should be associated with the project irrespective of the user, so I kind of like the idea of having it be an "always available" icon on the file tree, rather than keeping it in the user menu. @flukeout?

Contributor

Pomax commented Jan 28, 2017

It feels like exporting should be associated with the project irrespective of the user, so I kind of like the idea of having it be an "always available" icon on the file tree, rather than keeping it in the user menu. @flukeout?

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jan 28, 2017

Member

I'd vote for the download button beside the '+' icon over the file tree. @flukeout will need to approve whatever we do here.

Member

humphd commented Jan 28, 2017

I'd vote for the download button beside the '+' icon over the file tree. @flukeout will need to approve whatever we do here.

@sdalmeida

This comment has been minimized.

Show comment
Hide comment
@sdalmeida

sdalmeida Jan 29, 2017

Contributor

I also just thought about another option

capture4

Of course the icon will be changed to match the color scheme.

As for putting the icon on the file tree, what should be its behavior when the user minimizes the file tree? Should the Export button be hidden as well?
Waiting on @flukeout :)

Contributor

sdalmeida commented Jan 29, 2017

I also just thought about another option

capture4

Of course the icon will be changed to match the color scheme.

As for putting the icon on the file tree, what should be its behavior when the user minimizes the file tree? Should the Export button be hidden as well?
Waiting on @flukeout :)

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jan 29, 2017

Member

@Simon66 it's too niche a feature to highlight so prominently with such a significant UI addition.

Member

humphd commented Jan 29, 2017

@Simon66 it's too niche a feature to highlight so prominently with such a significant UI addition.

@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Jan 30, 2017

Contributor

Hey @Simon66 sorry for the hold up, made a note to jump on this first thing in the morning. Are you held up by design at this point?

Contributor

flukeout commented Jan 30, 2017

Hey @Simon66 sorry for the hold up, made a note to jump on this first thing in the morning. Are you held up by design at this point?

@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Jan 30, 2017

Contributor

Great work putting these options together, by the way. It does make sense putting the export feature closer to the files, it's an area that's visible for guests and signed-in users alike.

However, it clutters up that little bar with a feature that won't get used a lot. It might lead to mis-clicks which start a potentially big download immediately. Having just the small icon to communicate what it does might make the feature hard to find as well.

Another option would be to put a button below the list of files in the file tree. That gets more complicated though because we'd be messing with the brackets codebase. Is that something you'd be interested in exploring?

Anyway, I'll add some more thoughts tomorrow. I like the guest menu idea too.

Lastly I think Download files (.zip) might be a label that more people would understand.

Contributor

flukeout commented Jan 30, 2017

Great work putting these options together, by the way. It does make sense putting the export feature closer to the files, it's an area that's visible for guests and signed-in users alike.

However, it clutters up that little bar with a feature that won't get used a lot. It might lead to mis-clicks which start a potentially big download immediately. Having just the small icon to communicate what it does might make the feature hard to find as well.

Another option would be to put a button below the list of files in the file tree. That gets more complicated though because we'd be messing with the brackets codebase. Is that something you'd be interested in exploring?

Anyway, I'll add some more thoughts tomorrow. I like the guest menu idea too.

Lastly I think Download files (.zip) might be a label that more people would understand.

@Pomax

This comment has been minimized.

Show comment
Hide comment
@Pomax

Pomax Jan 30, 2017

Contributor

another thought, what if "files" itself is a dropdown menu? [files ▽] with under that some options like "new file", "export", "import" etc, while keeping the dedicated [+] and collapse option?

Contributor

Pomax commented Jan 30, 2017

another thought, what if "files" itself is a dropdown menu? [files ▽] with under that some options like "new file", "export", "import" etc, while keeping the dedicated [+] and collapse option?

@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Jan 30, 2017

Contributor

Given all of the options, I'd like to go with the following...

image

The icon need some work, I'll create it.

Benefits

  • This menu is already built and is tied closely with file-related actions

Drawbacks

  • We lose the "+" icon, which is a super obvious for adding new files

However, with the right Icon, I think that's OK.

Contributor

flukeout commented Jan 30, 2017

Given all of the options, I'd like to go with the following...

image

The icon need some work, I'll create it.

Benefits

  • This menu is already built and is tied closely with file-related actions

Drawbacks

  • We lose the "+" icon, which is a super obvious for adding new files

However, with the right Icon, I think that's OK.

@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Jan 30, 2017

Contributor

I also considered this approach, which is an adaptation of @Pomax's idea..

image

I think this works pretty well also, but it's not as obvious and removes a common UI element that our users are already familiar with. Another drawback is that it would be the only section heading that has a menu.

Contributor

flukeout commented Jan 30, 2017

I also considered this approach, which is an adaptation of @Pomax's idea..

image

I think this works pretty well also, but it's not as obvious and removes a common UI element that our users are already familiar with. Another drawback is that it would be the only section heading that has a menu.

@Pomax

This comment has been minimized.

Show comment
Hide comment
@Pomax

Pomax Jan 30, 2017

Contributor

fair points - I'm kind of missing a "create a file" without html/css/js enforcement but for the Thimble audience that might not be a real problem. This would be a great menu to also include an option to "import files (.zip)", to allow importing a full project from zip file (I forget which issue we have open for that at the moment...)

Contributor

Pomax commented Jan 30, 2017

fair points - I'm kind of missing a "create a file" without html/css/js enforcement but for the Thimble audience that might not be a real problem. This would be a great menu to also include an option to "import files (.zip)", to allow importing a full project from zip file (I forget which issue we have open for that at the moment...)

@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Jan 30, 2017

Contributor

Are you missing it for your own work flow? You can right-click the file tree and do it via the context menu.

Contributor

flukeout commented Jan 30, 2017

Are you missing it for your own work flow? You can right-click the file tree and do it via the context menu.

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jan 30, 2017

Member

I love this change, and moving "Download files (.zip)" into that menu. Great idea.

Member

humphd commented Jan 30, 2017

I love this change, and moving "Download files (.zip)" into that menu. Great idea.

@Pomax

This comment has been minimized.

Show comment
Hide comment
@Pomax

Pomax Jan 30, 2017

Contributor

yeah I've been using the "hidden" right click menu in the file browser a lot, but I'm a bit more of a poweruser than most thimble users will be, I readily admit

Contributor

Pomax commented Jan 30, 2017

yeah I've been using the "hidden" right click menu in the file browser a lot, but I'm a bit more of a poweruser than most thimble users will be, I readily admit

@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Jan 30, 2017

Contributor

@humphd just to clarify, which of the two options are you referring to?

Edit: Dang, now I'm leaning towards the File heading dropdown (Option 2) instead. It just feels so obvious. I'll stew on it a bit more.

Contributor

flukeout commented Jan 30, 2017

@humphd just to clarify, which of the two options are you referring to?

Edit: Dang, now I'm leaning towards the File heading dropdown (Option 2) instead. It just feels so obvious. I'll stew on it a bit more.

@sdalmeida

This comment has been minimized.

Show comment
Hide comment
@sdalmeida

sdalmeida Jan 30, 2017

Contributor

@flukeout After looking at both options, I really like Option 2.
Let me know which option you prefer 👍

Contributor

sdalmeida commented Jan 30, 2017

@flukeout After looking at both options, I really like Option 2.
Let me know which option you prefer 👍

@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Jan 30, 2017

Contributor

@Simon66 I think you're right, and I think humph is referring to Option 2 as well. Let's roll with that, it feels better.

Contributor

flukeout commented Jan 30, 2017

@Simon66 I think you're right, and I think humph is referring to Option 2 as well. Let's roll with that, it feels better.

@humphd

This comment has been minimized.

Show comment
Hide comment
@humphd

humphd Jan 30, 2017

Member

I'm taking about this one:

image

Member

humphd commented Jan 30, 2017

I'm taking about this one:

image

@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Jan 30, 2017

Contributor

@Simon66 I'm going to collect some more feedback on this issue. In the meantime, continue with Option 1 - it's the easier change, and if we decide to move to option 2, we can re-style the menu and add the affordance to the Files title in phase 2.

Does that sound OK?

Contributor

flukeout commented Jan 30, 2017

@Simon66 I'm going to collect some more feedback on this issue. In the meantime, continue with Option 1 - it's the easier change, and if we decide to move to option 2, we can re-style the menu and add the affordance to the Files title in phase 2.

Does that sound OK?

@sdalmeida

This comment has been minimized.

Show comment
Hide comment
@sdalmeida

sdalmeida Jan 31, 2017

Contributor

Perfect! I'm going with Option 1. I mean, it should be an easy change if we decide with Option 2.
I'll work on it and wait for the new icon 👍

Contributor

sdalmeida commented Jan 31, 2017

Perfect! I'm going with Option 1. I mean, it should be an easy change if we decide with Option 2.
I'll work on it and wait for the new icon 👍

@sdalmeida

This comment has been minimized.

Show comment
Hide comment
@sdalmeida

sdalmeida Feb 1, 2017

Contributor

screen shot 2017-01-31 at 11 20 09 pm
Done! Waiting for the icon :)

Contributor

sdalmeida commented Feb 1, 2017

screen shot 2017-01-31 at 11 20 09 pm
Done! Waiting for the icon :)

@gideonthomas

This comment has been minimized.

Show comment
Hide comment
@gideonthomas

gideonthomas Feb 1, 2017

Member

@Simon66 nice work! Would you be able to open up a PR with your changes so far? You could mark it as [WIP] in the title so that we know that it's an in progress PR.

Member

gideonthomas commented Feb 1, 2017

@Simon66 nice work! Would you be able to open up a PR with your changes so far? You could mark it as [WIP] in the title so that we know that it's an in progress PR.

sdalmeida added a commit to sdalmeida/thimble.mozilla.org that referenced this issue Feb 1, 2017

sdalmeida added a commit to sdalmeida/thimble.mozilla.org that referenced this issue Feb 1, 2017

sdalmeida added a commit to sdalmeida/thimble.mozilla.org that referenced this issue Feb 1, 2017

@sdalmeida

This comment has been minimized.

Show comment
Hide comment
@sdalmeida

sdalmeida Feb 1, 2017

Contributor

Hummm... well... thats super annoying... There where issues with my branch and while trying to fix them, looks like they show up here haha.
Either way, they shouldn't show on the commit history.

I've created a pull request @gideonthomas (#1688)

Contributor

sdalmeida commented Feb 1, 2017

Hummm... well... thats super annoying... There where issues with my branch and while trying to fix them, looks like they show up here haha.
Either way, they shouldn't show on the commit history.

I've created a pull request @gideonthomas (#1688)

@Pomax

This comment has been minimized.

Show comment
Hide comment
@Pomax

Pomax Feb 1, 2017

Contributor

@Simon66 no worries, we can fix all of that with a rebase/squash once the code goes from work-in-progress to "read to be merged in" =)

Contributor

Pomax commented Feb 1, 2017

@Simon66 no worries, we can fix all of that with a rebase/squash once the code goes from work-in-progress to "read to be merged in" =)

@gideonthomas gideonthomas added this to TODO in Technical Debt Feb 3, 2017

@gideonthomas gideonthomas moved this from TODO to Needs Review in Technical Debt Feb 3, 2017

flukeout pushed a commit that referenced this issue Feb 8, 2017

[WIP]Added export to .zip when not logged in (#981) (#1688)
* Added export to .zip when not logged in (#981)

* Reverted en-GB locales

* Changed export button id

* Added file-white icon

* Updated icon to fix firefox issues
@gideonthomas

This comment has been minimized.

Show comment
Hide comment
@gideonthomas

gideonthomas Feb 9, 2017

Member

Fixed with adf9a5f

Member

gideonthomas commented Feb 9, 2017

Fixed with adf9a5f

@gideonthomas gideonthomas moved this from Needs Review to Closed in Technical Debt Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment