Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow project export to .zip file when not logged in #981
referenced this issue
Jan 19, 2016
Fixing this requires us to move the menu option for export out of the logged in user menu (or add a second menu option). Right now it looks like this:
Should we put a new button beside the '+' in the file tree that means "Download"? @flukeout, can you weigh in?
The code in Bramble that does the zip stuff is here https://github.com/mozilla/brackets/blob/master/src/extensions/default/bramble/lib/RemoteCommandHandler.js#L146-L148 (see
In Thimble you trigger it like this:
I also just thought about another option
Of course the icon will be changed to match the color scheme.
As for putting the icon on the file tree, what should be its behavior when the user minimizes the file tree? Should the Export button be hidden as well?
Great work putting these options together, by the way. It does make sense putting the export feature closer to the files, it's an area that's visible for guests and signed-in users alike.
However, it clutters up that little bar with a feature that won't get used a lot. It might lead to mis-clicks which start a potentially big download immediately. Having just the small icon to communicate what it does might make the feature hard to find as well.
Another option would be to put a button below the list of files in the file tree. That gets more complicated though because we'd be messing with the brackets codebase. Is that something you'd be interested in exploring?
Anyway, I'll add some more thoughts tomorrow. I like the guest menu idea too.
Lastly I think
Given all of the options, I'd like to go with the following...
The icon need some work, I'll create it.
However, with the right Icon, I think that's OK.
I also considered this approach, which is an adaptation of @Pomax's idea..
I think this works pretty well also, but it's not as obvious and removes a common UI element that our users are already familiar with. Another drawback is that it would be the only section heading that has a menu.
fair points - I'm kind of missing a "create a file" without html/css/js enforcement but for the Thimble audience that might not be a real problem. This would be a great menu to also include an option to "import files (.zip)", to allow importing a full project from zip file (I forget which issue we have open for that at the moment...)
@Simon66 I'm going to collect some more feedback on this issue. In the meantime, continue with Option 1 - it's the easier change, and if we decide to move to option 2, we can re-style the menu and add the affordance to the Files title in phase 2.
Does that sound OK?