New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1635 - Fixed logged in user dropdown menu easier to click #1697

Merged
merged 3 commits into from Feb 7, 2017

Conversation

Projects
None yet
3 participants
@raygervais
Contributor

raygervais commented Feb 3, 2017

This resolve #1635 the issue found here which made the clickable padding of the logged in user menu not register. To remedy, I increased the padding of the link itself and decreased the padding of the <li> element which surrounded it.

@gideonthomas gideonthomas requested a review from flukeout Feb 3, 2017

Update userbar.less
Removed 'px' from line 480 to satisfy coding standards.
@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Feb 6, 2017

Contributor

I'll test it out today.

Contributor

flukeout commented Feb 6, 2017

I'll test it out today.

@flukeout flukeout self-assigned this Feb 6, 2017

@flukeout

If you can fix up the one small issue I filed, then this will be good to go and I'll merge it in. Thank you!

Show outdated Hide outdated public/resources/stylesheets/userbar.less Outdated

@flukeout flukeout assigned raygervais and unassigned flukeout Feb 7, 2017

Update userbar.less
Removed the display:block property from <li> elements in the dropdown-content namespace.
@raygervais

This comment has been minimized.

Show comment
Hide comment
@raygervais

raygervais Feb 7, 2017

Contributor

@flukeout, I've fixed your requested change. If you need anything else, let me know.

Contributor

raygervais commented Feb 7, 2017

@flukeout, I've fixed your requested change. If you need anything else, let me know.

@flukeout

This comment has been minimized.

Show comment
Hide comment
@flukeout

flukeout Feb 7, 2017

Contributor

Tested & works - nice work @raygervais

Contributor

flukeout commented Feb 7, 2017

Tested & works - nice work @raygervais

@flukeout flukeout merged commit 50aeb1d into mozilla:master Feb 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raygervais

This comment has been minimized.

Show comment
Hide comment
@raygervais

raygervais Feb 8, 2017

Contributor

Thank you @flukeout, I look forward to contributing more to Thimble.

Contributor

raygervais commented Feb 8, 2017

Thank you @flukeout, I look forward to contributing more to Thimble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment