Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update publish popup title when project is live - Issue 1918 #2523
@flukeout @humphd My solution was to reuse the existing
@marcobeltempo before we go to land this, I need to show you how to rebase your work, since it looks like you've got a bunch of commits in here that aren't part of your patch (did you merge with master, maybe?). It's not a problem, we can fix it, but FYI, you don't need to do that while you're developing.
Good work so far @marcobeltempo!
I'm not sure how you managed to get it to revert back to "Publish this project" when you unpublish the project as I don't see code to handle that case. I added comments to suggest where to make those changes. Let me know if you're having trouble with getting it to work and please do rebase your changes before pushing them up.