Skip to content
This repository has been archived by the owner. It is now read-only.

Fixing #2518: Added a min-width to the homepage body to prevent content overflow #2534

Merged
merged 1 commit into from Oct 20, 2017

Conversation

@marcobeltempo
Copy link
Contributor

@marcobeltempo marcobeltempo commented Oct 20, 2017

Fixing #2518

Issue

If you resize the browser window while on the home screen, elements such as the video, and footer will begin to overflow.

31206109-e11e4f80-a943-11e7-8297-592aa7aa672f

Fix

I simply added a max-width: 981px; to the body tag in public/homepage/stylesheets/style.less

Result

31590096-b338cd1e-b1d8-11e7-9534-aabacd637dbe

@humphd humphd requested a review from flukeout Oct 20, 2017
@humphd
Copy link
Member

@humphd humphd commented Oct 20, 2017

Flagging @flukeout for review.

@flukeout
Copy link
Contributor

@flukeout flukeout commented Oct 20, 2017

Testing this out now.

@flukeout
Copy link
Contributor

@flukeout flukeout commented Oct 20, 2017

Thanks @marcobeltempo - tested this in a couple of browsers and it does the trick! Merging!

@flukeout flukeout merged commit 1345e56 into mozilla:master Oct 20, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@marcobeltempo marcobeltempo deleted the marcobeltempo:issue2518 branch Oct 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants