Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

reload button + disable JS checkbox #381

Merged
merged 2 commits into from Mar 7, 2014

Conversation

Projects
None yet
2 participants
Contributor

Pomax commented Mar 6, 2014

reload button is easy to test with

<!doctype html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Your Awesome Webpage created on Wed, Mar 5 2014 4:16 PM</title>
  </head>
  <body>
    <p>Make something amazing with the web</p>
    <button onclick="document.body.innerHTML = ''">try me </button>
  </body>
</html>

script disable is easy to test with

<!doctype html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Your Awesome Webpage created on Wed, Mar 5 2014 4:16 PM</title>
  </head>
  <body>
    <p>Make something amazing with the web</p>
    <script>alert("lol");</script>
  </body>
</html>

@ScottDowne ScottDowne commented on an outdated diff Mar 6, 2014

public/friendlycode/templates/previewloader.html
@@ -165,7 +175,7 @@
if(!owner) { owner = event.source; }
if ("sourceCode" in data && typeof data.sourceCode === "string") {
- content[data.type](data.sourceCode);
+ content["overwrite"](data);
@ScottDowne

ScottDowne Mar 6, 2014

Contributor

content.overwrite(data);

@Pomax Pomax added a commit that referenced this pull request Mar 7, 2014

@Pomax Pomax Merge pull request #381 from Pomax/jsrun
reload button + disable JS checkbox
5d656cc

@Pomax Pomax merged commit 5d656cc into mozilla:master Mar 7, 2014

1 check passed

default The Travis CI build passed
Details

@Pomax Pomax deleted the unknown repository branch Mar 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment