This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Bug 1077635 - Draw low-count job rows with consistent table appearance #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tojon
force-pushed
the
short-row-support
branch
from
f885ffe
to
6ffc69c
Compare
camd
pushed a commit
that referenced
this pull request
Oct 6, 2014
Bug 1077635 - Draw low-count job rows with consistent table appearance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supplementary to already landed work in Bugzilla bug 1077635.
I noticed an edge case this morning, where a newly building resultset may not have enough job elements to fill the parent container, at certain browser widths. This change addresses that, ensuring all low-count job rows are consistent and their resultsets don't look 'ragged' in the UI.
Here's the before and after:
I think we should only land this tweak once we know the alternate colors in the previous PR #216 has been signed off by the sheriffs on dev. It does look nice though :)
Tested on Windows:
FF Release 32.0.3
Chrome Latest Release 37.0.2062.124 m
Adding @edmorley for visibility and @camd for review.