From 39e5e7c4ea3adae6aec3a39973113d35aef218f0 Mon Sep 17 00:00:00 2001
From: Shruti Jasoria <SJasoria@users.noreply.github.com>
Date: Tue, 11 Apr 2017 17:55:46 +0530
Subject: [PATCH] Bug 1352207 - Compare view should show a tooltip on bars
 saying whether the result was better or worse (#2333)

---
 ui/js/filters.js                   | 6 ++++++
 ui/partials/perf/comparetable.html | 5 ++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/ui/js/filters.js b/ui/js/filters.js
index 7210ec34ae6..31de992cac1 100755
--- a/ui/js/filters.js
+++ b/ui/js/filters.js
@@ -183,3 +183,9 @@ treeherder.filter('displayPrecision', function() {
         return parseFloat(input).toFixed(2);
     };
 });
+
+treeherder.filter('absoluteValue', function() {
+    return function(input) {
+        return Math.abs(input);
+    };
+});
diff --git a/ui/partials/perf/comparetable.html b/ui/partials/perf/comparetable.html
index bcb373d90ee..106c853f785 100644
--- a/ui/partials/perf/comparetable.html
+++ b/ui/partials/perf/comparetable.html
@@ -82,7 +82,10 @@
                     replicates="compareResult.newRuns"></ph-average>
       </td>
       <td ng-class="$ctrl.getCompareClasses(compareResult)">
-        <span ng-if="compareResult.delta" class="detail-hint" uib-tooltip="Mean difference: {{compareResult.delta|displayPrecision}} (= {{compareResult.deltaPercentage|displayPrecision}}%)">
+        <span ng-if="compareResult.delta  && compareResult.newIsBetter" class="detail-hint" uib-tooltip="Mean difference: {{compareResult.delta|displayPrecision}} (= {{compareResult.deltaPercentage|displayPrecision|absoluteValue}}% better)">
+          {{compareResult.deltaPercentage|displayPrecision}}%  
+        </span>
+        <span ng-if="compareResult.delta  && !compareResult.newIsBetter" class="detail-hint" uib-tooltip="Mean difference: {{compareResult.delta|displayPrecision}} (= {{compareResult.deltaPercentage|displayPrecision|absoluteValue}}% worse)">
           {{compareResult.deltaPercentage|displayPrecision}}%
         </span>
       </td>