Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable few linting rules - batch #1 #5469

Open
armenzg opened this issue Oct 8, 2019 · 4 comments · May be fixed by #5523

Comments

@armenzg
Copy link
Contributor

@armenzg armenzg commented Oct 8, 2019

Remove these lines:

    class-methods-use-this': 'off',
    'consistent-return': 'off',
    'default-case': 'off',

and make sure yarn lint passes before opening a PR.

Thanks!

@rbrishabh

This comment has been minimized.

Copy link

@rbrishabh rbrishabh commented Oct 8, 2019

Hey @armenzg!

Thank you! I will take this up! =)

@armenzg

This comment has been minimized.

Copy link
Contributor Author

@armenzg armenzg commented Oct 8, 2019

👍

@VCDmoose

This comment has been minimized.

Copy link

@VCDmoose VCDmoose commented Oct 16, 2019

I can look into this.

@rbrishabh

This comment has been minimized.

Copy link

@rbrishabh rbrishabh commented Oct 16, 2019

Hey! @VCDmoose, I'm almost done with this. I'll be putting up a PR today! :)

@rbrishabh rbrishabh referenced a pull request that will close this issue Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.