Changes from current production sentry svn repo #19

Merged
merged 3 commits into from Oct 17, 2012

Conversation

Projects
None yet
3 participants
Contributor

superawesome commented Oct 16, 2012

Various things that are done in the current production sentry node, pulled from its SVN repo.

Of particular note is the changes around retrying failed products/mirrors.

@fwenzel fwenzel commented on an outdated diff Oct 16, 2012

sentry/sentry-multi.pl
@@ -45,7 +45,8 @@
} else {
die "couldn't fork: $!\n";
}
- sleep 1; # wait a second between each spawn so we don't hose the system by spawning all children at once
+ # don't need to sleep anymore because of the $num_children check.
@fwenzel

fwenzel Oct 16, 2012

Member

Just remove the line then :)

@fwenzel fwenzel and 1 other commented on an outdated diff Oct 16, 2012

sentry/sentry.pl
@@ -219,7 +236,7 @@ sub log_this {
}
}
elsif ($filepath =~ m!/seamonkey/!) {
- if ($filepath =~ m!2\.0\.5!) {
+ if (($filepath =~ m!2\.0\.5!) || ($filepath =~ m!2\.0\.6!)) {
@fwenzel

fwenzel Oct 16, 2012

Member

uh, this indentation is off.

Also, I guess a comment wouldn't have hurt here.

@superawesome

superawesome Oct 17, 2012

Contributor

This chooses which locale should be tested. Historically we test the alphabetically last locale available, because rsync generally runs in alphabetical order... the thinking is that if the last locale exists, then the other do too. It's inherently a trade-off designed to avoid having to test every single locale individually.

I read this as "if seamonkey, and if it's version 2.0.5 or 2.0.6, check zh-CN. For all other versions, check tr".

Based on wandering around here: http://download.cdn.mozilla.net/pub/seamonkey/releases/ ... it appears that Seamonkey did indeed have zh-CN support for those two versions, and potentially a few others. However it was not consistent. 2.1 did not have it... 2.13 (current) has zh-CN and zh-TW. In many versions, "tr" was indeed the alphabetically-last locale.

However, for the most part it doesn't matter anymore. The lone mirrors are reverse-proxying CDNs, not rsync-based. The logic of checking the last locale no longer holds any real value... any locale is just as good as any other. We still need to check a locale, but it doesn't matter which one.

Member

fwenzel commented Oct 17, 2012

This looks good now, thanks Jake. Looks like these are various tweaks presumably written by justdave for sentry and sentry viewer. Thanks for porting them!

Member

fwenzel commented Oct 17, 2012

Do you want to merge this yourself? Otherwise, @brandonsavage or @rik ?

@brandonsavage brandonsavage added a commit that referenced this pull request Oct 17, 2012

@brandonsavage brandonsavage Merge pull request #19 from superawesome/master
Changes from current production sentry svn repo
a053195

@brandonsavage brandonsavage merged commit a053195 into mozilla:master Oct 17, 2012

Contributor

superawesome commented Oct 17, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment