Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse separate highlight styles for different platforms #78
Comments
6a68
added
good first bug
size:small
status:defined
labels
Mar 10, 2016
6a68
assigned
kaganjd
Mar 17, 2016
This comment has been minimized.
This comment has been minimized.
starting to dig into this one! |
6a68
added
status:in progress
and removed
status:defined
labels
Mar 17, 2016
6a68
closed this
in
e48ac29
Mar 23, 2016
6a68
removed
the
status:in progress
label
Mar 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6a68 commentedMar 10, 2016
_This might be a little too ambitious for a good first bug, so if you are a new contributor and are interested in taking this on, please ping me to get guidance before you start. IRC is best (my nick is 6a68), or leave a comment in this bug.
Right now, we style the recommendation the same way for all platforms. In general, this is fine, but it would be nice to have platform-specific highlight behavior when the recommendation row is selected.
Here's a sketch of the tasks required:
chrome/skin/
directory for mac, windows, and linux..autocomplete-richlistitem[selected=true]
rules, but apply them to the#universal-search-recommendation
selector.Services.appinfo.OS
. The possible values of interest are'Darwin'
, 'Linux'
, and'WINNT'
. (It takes about 4 hops in MDN to track this info down, directly inserting the answer here to keep the bug manageable overall.)