Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
buttons for closing pop-ups are inconsistent #930
There are two buttons "Return to Languages" and "Return to Common Voice" on the same page (Languages)
But one looks like a link and the other one looks like a button (different css)
Also: the strings don't match/it looks inconsistent.
In german I translated the first string like the second one, so it matches up (simply "Return to Common Voice" in both cases).
I also found it a bit weird to have two buttons: close form and return to common voice, that do the same thing.
a possible string, that might be better:
Thanks for flagging this @Djfe, much appreciated!
In this instance the
I just noticed, that not only is the "Get Involved" overlay flow displayed on the main page atm. (release server only), but the button also says
Just thought, you might wanna know that. :)
@Djfe on my end both staging and production are showing the proper flows for our current iteration:
Perhaps I'm misunderstanding what you're referencing? A screenshot may help too.