New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons for closing pop-ups are inconsistent #930

Closed
Djfe opened this Issue Apr 19, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@Djfe
Contributor

Djfe commented Apr 19, 2018

There are two buttons "Return to Languages" and "Return to Common Voice" on the same page (Languages)
They are displayed in the pop-ups of that page.

But one looks like a link and the other one looks like a button (different css)

Also: the strings don't match/it looks inconsistent.
The same goes for: "Exit form" and "Exit"

In german I translated the first string like the second one, so it matches up (simply "Return to Common Voice" in both cases).

I also found it a bit weird to have two buttons: close form and return to common voice, that do the same thing.
This should be changed somehow IMO.

a possible string, that might be better:
"Continue"

String one:
screenshot

String two:
screenshot

@mikehenrty

This comment has been minimized.

Contributor

mikehenrty commented Apr 19, 2018

flagging @m-branson for awareness

@mbransn

This comment has been minimized.

Collaborator

mbransn commented Apr 19, 2018

Thanks for flagging this @Djfe, much appreciated!

For Exit and Exit Form we are working to consolidate this into a simple X icon which will close any overlay and route back to the origin screen.

For the Return to ... buttons, this is an artifact of iterative design process. 😬 Two thoughts:

  • Visually: both instances should utilize the latest version of black button UI. @Gregoor apologies here as this is my inconsistency.
  • Functionally: (for the moment**) button routing is correct. This provides a user experience that accommodates different user types: those that are comfortable closing/exiting an overlay vs. those that prefer a button style call to action.
    **It is our goal in the very near future to instead route users more effectively for the project; e.g. Share the Common Voice Project (provides UI to share socially or via URL) or Ready to record some clips? (prompts and routes users to make contributions if their language is available)

Regarding this:

In german I translated the first string like the second one, so it matches up (simply "Return to Common Voice" in both cases).

In this instance the Return to Languages option should be routing to the Languages page, this is why we've used this copy rather than Return to Common Voice. If possible it'd be great to keep Return to Languages as button copy for the Get Involved overlay flow.

cc @mikehenrty @flekkowich

@Djfe

This comment has been minimized.

Contributor

Djfe commented May 10, 2018

In this instance the Return to Languages option should be routing to the Languages page, this is why we've used this copy rather than Return to Common Voice. If possible it'd be great to keep Return to Languages as button copy for the Get Involved overlay flow.

I just noticed, that not only is the "Get Involved" overlay flow displayed on the main page atm. (release server only), but the button also says Return to Languages

Just thought, you might wanna know that. :)

@mbransn

This comment has been minimized.

Collaborator

mbransn commented May 10, 2018

I just noticed, that not only is the "Get Involved" overlay flow displayed on the main page atm. (release server only), but the button also says Return to Languages

@Djfe on my end both staging and production are showing the proper flows for our current iteration:

  • Request a Language on the homepage and within the banner on Laguages page
  • Get Involved on the Languages page for each language

Perhaps I'm misunderstanding what you're referencing? A screenshot may help too.

@Djfe

This comment has been minimized.

Contributor

Djfe commented May 10, 2018

yeah, probably because it only shows up for other languages than English ^^
screenshot_20180510-215246
change it to German and click on "mitmachen" ;)

@mbransn

This comment has been minimized.

Collaborator

mbransn commented May 10, 2018

Ah yes, this explains very well why I didn't know it was incorrect! Thanks for clarifying and QA'ing @Djfe 👍

@Gregoor can you look into this and ensure the strings are updated for our next push? (Wondering if this may be left over due to translation freeze prior to our last push?)

@Gregoor

This comment has been minimized.

Collaborator

Gregoor commented May 11, 2018

Oh right, when we were building that we were only thinking about opening up from the languages page I guess. I'll see if I can find an existing string which we can show on the home get-involved instead.

@mbransn

This comment has been minimized.

Collaborator

mbransn commented May 11, 2018

@Gregoor I believe this should be Return to Common Voice?

@Gregoor Gregoor closed this in f9306b2 May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment