Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another italian review to improve the sentences #1806

Merged
merged 2 commits into from Feb 20, 2019

Conversation

Projects
None yet
4 participants
@Mte90
Copy link
Contributor

commented Feb 14, 2019

We worked on cleaning, fix typos and remove duplicates.

Sav22999 added some commits Feb 5, 2019

Some corrections (#36)
* Frasi revisionate, con molte modifiche
@Gregoor

This comment has been minimized.

Copy link
Collaborator

commented Feb 14, 2019

Thanks, I'm gonna merge this one, but could we in the future do this for sentences that are wrong:

create a PR to remove this and then use the sentence collection tool to add it?

@Mte90

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

ok but right now in this pr we didn't added new sentences only fix on the previous.
about the sentence collector I don't know if fit the italia ncase because we have our linter for the sentences

@Gregoor

This comment has been minimized.

Copy link
Collaborator

commented Feb 14, 2019

We can add that linter into the existing process. @nukeador might have some pointers for you for that.

RE it just being changes: Common Voice doesn't know of corrections, so they just appear as new sentences.

@nukeador

This comment has been minimized.

Copy link
Collaborator

commented Feb 14, 2019

Daniele, we can talk about this but definitely we need hundreds of thousands sentences per language if we want to reach someday the 2000hrs, there is going be to always a need for new sentences ;-)

@Gregoor Gregoor merged commit 6053a3c into mozilla:master Feb 20, 2019

7 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - android/app/build.gradle (Gregoor) No manifest changes detected
security/snyk - android/build.gradle (Gregoor) No manifest changes detected
security/snyk - common/package.json (Gregoor) No manifest changes detected
security/snyk - package.json (Gregoor) No new issues
Details
security/snyk - server/package.json (Gregoor) No new, high severity issues
Details
security/snyk - web/package.json (Gregoor) No new, high severity issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.