Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added eslint rule for shorthand property assignment #695

Merged
merged 2 commits into from Dec 20, 2016

Conversation

Projects
None yet
4 participants
@shubheksha
Copy link
Contributor

commented Dec 20, 2016

Fixes #693

@@ -41,7 +41,7 @@ module.exports = {
libraryTarget: 'commonjs2',
},
module: {
preLoaders: preLoaders,
preLoaders,

This comment has been minimized.

Copy link
@kumar303

kumar303 Dec 20, 2016

Member

Does this work? I don't know if the webpack config file is run through babel. It may need to be ignored by eslint for this rule.

This comment has been minimized.

Copy link
@shubheksha

shubheksha Dec 20, 2016

Author Contributor

Yep, it works! All the tests are passing.

This comment has been minimized.

Copy link
@kumar303

kumar303 Dec 20, 2016

Member

I don't know if the tests will cover this. Does npm run build still work?

This comment has been minimized.

Copy link
@shubheksha

shubheksha Dec 20, 2016

Author Contributor

Yes, it does.

This comment has been minimized.

Copy link
@kumar303
@coveralls

This comment has been minimized.

Copy link

commented Dec 20, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling d670fde on shubheksha:fix/693 into f79e006 on mozilla:master.

@kumar303 kumar303 self-assigned this Dec 20, 2016

@kumar303
Copy link
Member

left a comment

Thanks sj!

@kumar303 kumar303 merged commit 75c5671 into mozilla:master Dec 20, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.