Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
PDK5 sites: Stay with the whitelist approach or build something that detects CDN loads? #43
Sure, here's a link to the XPI of my POC: https://thomas.tanrei.ca/moz/pdk5fix.xpi
All that's needed to add to its list of CDNs is to find the URL variant that accesses the tdPdk.js script, and wildcard it as seen in the background.js. It might be worth testing PDK4 and lower too, if we ever find a site still using it (a UA-spoof might work fine for lower versions too).
I used BigQuery + HTTP Archive to find sites in their latest million or so pages mobile run:
Just 47 sites (matching against
referenced this issue
Apr 8, 2019
It turns out that simply spoofing the UA may be a bit much; Cooking Channel TV's site ran into long delays loading the page, for instance. As such I've decided to just edit the incoming scripts to apply the fix I suggested in https://webcompat.com/issues/8410 (basically, changing the string
This approach seems to be working fine on at least these sites (of course, after turning off any existing UA overrides we have for these sites in
In addition, it works fine on a version of PDK (18.104.22.1686014) which doesn't need the fix and already works on Fennec (https://webcompat.com/issues/2351 is working now). It also avoids doing any UA spoofing, which is a likely win for metrics.