Skip to content
This repository has been archived by the owner on Apr 1, 2019. It is now read-only.

Simplify Responses for Rect type calls to use same struct and impl #101

Merged
merged 1 commit into from Jun 15, 2017

Conversation

AutomatedTester
Copy link

@AutomatedTester AutomatedTester commented Jun 9, 2017

This merges the WindowRectResponse and ElementRectResponse into
a single struct. It also moves the types in the struct to floats which
aligns with the WebDriver specification as in
https://w3c.github.io/webdriver/webdriver-spec.html#get-element-rect
and in https://w3c.github.io/webdriver/webdriver-spec.html#dfn-window-rect


This change is Reviewable

This merges the WindowRectResponse and ElementRectResponse into
a single struct. It also moves the types in the struct to floats which
aligns with the WebDriver specification as in
https://w3c.github.io/webdriver/webdriver-spec.html#get-element-rect
and in https://w3c.github.io/webdriver/webdriver-spec.html#dfn-window-rect
@andreastt andreastt merged commit 1c59375 into mozilla:master Jun 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants