[MIGRATED] Implement Error states

[thisandagain]

We need to have error states when creating / editing / deleting on projects, pages, and elements.

[flukeout]

List of possible errors

• Username too short or too long
• Username contains illegal characters
• Failed to create a new project
• Failed to delete a project
• Failed to load a project
• Failed to load list of projects in Make or Discover views
• Failed to load an image in a project
• Failed to load a page within a project
• Failed to upload an image when editing a project

@k88hudson Can you help flesh out this list with the places you've identified in the app?

[k88hudson]

Here is a list for each view:

General

• User loses/has no network connection
• Network request is taking a long time
• Network request times out

Discover

• Discover gallery fails to load
• Discover gallery has no items

Make

• Make gallery fails to load
• Make gallery has no items
• Create new project fails

Project

• Project fails to load/not found
• Project is empty, attempt to create first page fails*
• Create new page fails
• Delete page fails

*Note: This is when a project is first created, has no pages, and the first page is created. This may need some specific behaviour here, like a prompt to re-try creating the first page... unless we can simplify creating the first page to a single request mozilla/api.webmaker.org#53

Page

• Page fails to load/not found
• Position update fails (scale, translation, etc.)
• Create new element fails
• Delete element fails

Element editor

• Element fails to load/not found
• Style/attribute update fails

Tinker mode

• Element fails to load/not found
• Style/attribute update fails

[k88hudson]

SO MUCH ERROR ⚠️

[flukeout]

@k88hudson I started some work in The Error States Diagram - please have a look over it and let me know your thoughts about the general structure. Give me a ping when you can chat, I have some questions.

We can work out error message wording later.

[flukeout]

@vazquez Has already done some work on No internet in Discover mode state.

[xmatthewx]

@flukeout - your spec on these states looks great. You've nicely divided things we should report via

• the view background
• a snackbar notification (material docs)

I think we need a review from an engineering perspective on what's feasible to build this heartbeat (and if we'll need to adjust design to fit that scope).

cc @Pomax

[xmatthewx]

@Pomax - can you review this doc? The Error States Diagram

What do you think is feasible to build this heartbeat?

[Pomax]

this is going to depend on how much time solving #1946 leaves. A number of these are snackbar errors, which seems the most promising UI to start with.

[Pomax]

started with implementing a tester for "snackbar" notification in #2080, which can then be used to move several of our "currently console.error" errors into

[Pomax]

Also wrapping:

• sign-in failure
• sign-up failure

[xmatthewx]

Are we in good enough shape for our next release? If so, let's close this and file any follow up necessary. @Pomax @thisandagain

[cadecairos]

Also wrapping:

sign-in failure
sign-up failure

@Pomax I recall seeing duplicate errors here when signing up, one on the page, and one "snackbar" style. is that still the case?

[toolness]

This issue has been moved to mozilla/webmaker-core#125.
Please don't comment on it here.