Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue208 Newspaper Template #348
You're right; there is indeed a CSS bug, although it appears that it's taken care of in #343. Your patch is good otherwise except for some indentation issues in the JSON
In terms of the content of this patch, I think you could do a little more to make this follow the style of a 'Newspaper' article. Check out this screenshot of a Toronto Star article:
Hey @rdaoud1! Looking good. One problem is it looks like your last commit caused an issue. It looks like you may have run it through a JSON auto-formatter that caused the build to fail. Can you rollback that last commit (http://stackoverflow.com/questions/927358/undo-the-last-git-commit)? Also, when you write commit messages it's really helpful if you write down exactly what you did that makes it different from the last commit. For example, you have four commits that say something along the lines of "new newspaper template design". It's really helpful if you are explicit about each change.
Thanks and I hope that helps!