Skip to content

Commit e4c6417

Browse files
Mark CôtéMark Côté
authored andcommitted
Bug 1123143 - Add links to MozReview diffs to MozReview table. r=glob
Each child review-request summary is prefaced with the abbreviated commit hash, which is also a link to the diff. This looks similar to the summary table in MozReview itself.
1 parent de34aed commit e4c6417

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

extensions/MozReview/web/js/mozreview.js

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,28 @@ MozReview.getReviewRequest = function() {
2222
return rrUiBaseUrl + rrId + '/';
2323
}
2424

25+
function rrDiffUrl(rrId) {
26+
return rrUrl(rrId) + 'diff/#index_header';
27+
}
28+
2529
function rrRow(rr, isParent) {
2630
var tdSummary = td.clone();
2731
var trCommit = tr.clone();
28-
var a = $('<a/>');
32+
var reviewLink = $('<a/>');
33+
var diffLink = reviewLink.clone();
2934

3035
if (!isParent) {
3136
tdSummary.addClass('mozreview-child-request-summary');
37+
diffLink.attr('href', rrDiffUrl(rr.id));
38+
diffLink.text(rr.commit.substr(0, 12));
39+
diffLink.addClass('mozreview-diff-link');
40+
tdSummary.append(diffLink);
41+
tdSummary.append(' ');
3242
}
3343

34-
a.attr('href', rrUrl(rr.id));
35-
a.text(rr.summary);
36-
tdSummary.append(a);
44+
reviewLink.attr('href', rrUrl(rr.id));
45+
reviewLink.text(rr.summary);
46+
tdSummary.append(reviewLink);
3747

3848
if (isParent) {
3949
tdSummary.append($('<span/>').text(' (' + rr.submitter + ')'));

extensions/MozReview/web/style/mozreview.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@
5353
text-indent: 1em;
5454
}
5555

56+
.mozreview-diff-link {
57+
font-family: monospace;
58+
}
59+
5660
/* bug-modal specific */
5761

5862
#module-mozreview-requests .module-content {

0 commit comments

Comments
 (0)