New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the error panel #95

Merged
merged 1 commit into from Feb 28, 2016

Conversation

Projects
None yet
4 participants
@martiansideofthemoon
Copy link
Contributor

martiansideofthemoon commented Feb 25, 2016

Follow up of #82. All commits of #82 imported here thus far. Fixes #13

Review on Reviewable

@hejbot

This comment has been minimized.

Copy link

hejbot commented Feb 25, 2016

The following reviewer was randomly selected for this PR: @jgraham
And the following additional people are watching it:

@martiansideofthemoon martiansideofthemoon force-pushed the martiansideofthemoon:charizard branch 7 times, most recently from 4ffa425 to 2b70bf3 Feb 25, 2016

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Feb 25, 2016

@martiansideofthemoon Did you squash commits ? There were more commits after this.

@martiansideofthemoon

This comment has been minimized.

Copy link
Contributor

martiansideofthemoon commented Feb 25, 2016

@CodeMaxx , yeah had to squash it. Resolving the conflict was impossible without doing so. Also, I've removed the indentation in index.html to make the diff readable

@jgraham

This comment has been minimized.

Copy link
Collaborator

jgraham commented Feb 26, 2016

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.


index.html, line 150 [r1] (raw file):
This panel should be zero-height when not displayed, at the moment it seems to always take up the bottom 15% of the screen.


index.html, line 152 [r1] (raw file):
Ideally the expected and got text would use the same styles as the corresponding table cells.


wptview.css, line 26 [r1] (raw file):
This doesn't seem much like it will match the other text on the page; I would try the Mono versions of the fonts defined on :root


Comments from the review on Reviewable.io

@martiansideofthemoon martiansideofthemoon force-pushed the martiansideofthemoon:charizard branch from 2b70bf3 to 0ba1a91 Feb 27, 2016

@jgraham

This comment has been minimized.

Copy link
Collaborator

jgraham commented Feb 28, 2016

Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from the review on Reviewable.io

jgraham added a commit that referenced this pull request Feb 28, 2016

@jgraham jgraham merged commit 661ec7a into mozilla:master Feb 28, 2016

1 check passed

code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details

@martiansideofthemoon martiansideofthemoon deleted the martiansideofthemoon:charizard branch Feb 28, 2016

@arpan98 arpan98 referenced this pull request Jun 8, 2016

Merged

Added warnings UI #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment