Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

remove Developer Comments (bug 783673)

  • Loading branch information...
commit 0bba7baf5e9ced41e0b6f6f0137b7f57245d6746 1 parent 98d26a1
@cvan cvan authored
View
3  media/css/devreg/manage.styl
@@ -253,8 +253,7 @@ label.above-the-field .locale {
/*
Bug 622030- TODO (potch) fix this later
-#addon-description,
-#developer_comments {
+#addon-description {
max-height: 6.4em;
overflow: hidden;
}
View
2  media/js/mkt/detail.js
@@ -10,7 +10,7 @@
// Toggle "more..." or "less..." text.
$this.attr('data-toggle-text', $this.text());
$this.text(newTxt);
- // Toggle description + developer comments.
+ // Toggle description.
$this.closest('.blurbs').find('.collapsed').toggle();
})).on('click', '.approval-pitch', _pd(function() {
$('#preapproval-shortcut').submit();
View
9 mkt/detail/templates/detail/app.html
@@ -76,8 +76,7 @@
{% set summary_len = product.summary.__unicode__()|length if product.summary else 0 %}
{% set descr_len = product.description.__unicode__()|length if product.description else 0 %}
- {% set comments_len = product.developer_comments.__unicode__()|length if product.developer_comments else 0 %}
- {% set super_long = (summary_len + descr_len + comments_len) > 700 %}
+ {% set super_long = (summary_len + descr_len) > 700 %}
<section class="main blurbs infobox">
<div>
<p class="summary">
@@ -86,16 +85,12 @@
<a href="#" class="show-toggle" data-toggle-text="{{ _('Less&hellip;') }}">{{ _('More&hellip;') }}</a>
{% endif %}
</p>
- {% if descr_len or comments_len or product.is_packaged %}
+ {% if descr_len or product.is_packaged %}
<div{% if super_long %} class="collapsed"{% endif %}>
{% if descr_len %}
<h3>{{ _('Description') }}</h3>
<div class="description">{{ product.description|nl2br }}</div>
{% endif %}
- {% if comments_len %}
- <h3>{{ _('Developer Comments') }}</h3>
- <div class="developer-comments">{{ product.developer_comments|nl2br }}</div>
- {% endif %}
{% if product.is_packaged %}
<h3>{{ _('Version') }}</h3>
<div class="package-version">
View
12 mkt/detail/tests/test_views.py
@@ -262,15 +262,6 @@ def test_has_description(self):
description = self.get_pq()('.description')
eq_(description.text(), self.app.description)
- def test_no_developer_comments(self):
- eq_(self.get_pq()('.developer-comments').length, 0)
-
- def test_has_developer_comments(self):
- self.app.developer_comments = 'hot ish is coming brah'
- self.app.save()
- eq_(self.get_pq()('.developer-comments').text(),
- self.app.developer_comments)
-
def test_has_version(self):
self.app.summary = ''
self.app.description = ''
@@ -282,9 +273,6 @@ def test_has_version(self):
eq_(version.text(),
'Latest version: %s' % str(self.app.current_version))
- def test_no_support(self):
- eq_(self.get_pq()('.developer-comments').length, 0)
-
def test_has_support_email(self):
self.app.support_email = 'gkoberger@mozilla.com'
self.app.save()
View
3  mkt/developers/forms.py
@@ -933,12 +933,11 @@ def __init__(self, locale, *args, **kw):
class AppFormTechnical(addons.forms.AddonFormBase):
- developer_comments = TransField(widget=TransTextarea, required=False)
flash = forms.BooleanField(required=False)
class Meta:
model = Addon
- fields = ('developer_comments', 'public_stats')
+ fields = 'public_stats',
def __init__(self, *args, **kw):
super(AppFormTechnical, self).__init__(*args, **kw)
View
26 mkt/developers/templates/developers/apps/edit/technical.html
@@ -15,32 +15,6 @@
<tbody>
<tr>
<th>
- <label data-for="developer_comments">
- {{ _("Developer Comments") }}
- {{ tip(None,
- _("Any information end users may want to know that
- isn't necessarily applicable to the app summary
- or description. Common uses include listing known
- major bugs, information on how to report bugs,
- anticipated release date of a new version, etc.")) }}
- </label>
- </th>
- <td>
- {% if editable %}
- {{ form.developer_comments }}
- {{ form.developer_comments.errors }}
- {{ some_html_tip() }}
- {% else %}
- {% call empty_unless(addon.developer_comments) %}
- <div id="developer_comments" class="prose">
- {{ addon|all_locales('developer_comments') }}
- </div>
- {% endcall %}
- {% endif %}
- </td>
- </tr>
- <tr>
- <th>
<label for="flash">
{{ _('Uses Flash') }}
{{ tip(None,
View
38 mkt/developers/tests/test_views_edit.py
@@ -1100,48 +1100,30 @@ def setUp(self):
def test_form_url(self):
self.check_form_url('technical')
- def test_log(self):
- data = formset(developer_comments='This is a test')
- o = ActivityLog.objects
- eq_(o.count(), 0)
- r = self.client.post(self.edit_url, data)
- self.assertNoFormErrors(r)
- eq_(o.filter(action=amo.LOG.EDIT_PROPERTIES.id).count(), 1)
-
def test_toggles(self):
# Turn everything on.
- data = dict(developer_comments='Test comment!',
- flash='checked')
+ data = dict(flash='checked')
r = self.client.post(self.edit_url, formset(**data))
self.assertNoFormErrors(r)
- expected = dict(developer_comments='Test comment!',
- uses_flash=True)
- self.compare(expected)
+ self.compare({'uses_flash': True})
# And off.
- r = self.client.post(self.edit_url,
- formset(developer_comments='Test comment!'))
- expected.update(uses_flash=False)
- self.compare(expected)
-
- def test_devcomment_optional(self):
- data = dict(developer_comments='')
- r = self.client.post(self.edit_url, formset(**data))
- self.assertNoFormErrors(r)
-
- expected = dict(developer_comments='')
- self.compare(expected)
+ r = self.client.post(self.edit_url)
+ self.compare({'uses_flash': False})
def test_public_stats(self):
+ o = ActivityLog.objects
+ eq_(o.count(), 0)
+
eq_(self.webapp.public_stats, False)
assert not self.webapp.public_stats, (
'Unexpectedly found public stats for app. Says Basta.')
- data = dict(public_stats=True)
- r = self.client.post(self.edit_url, formset(**data))
+ r = self.client.post(self.edit_url, formset(public_stats=True))
self.assertNoFormErrors(r)
- self.compare(dict(public_stats=True))
+ self.compare({'public_stats': True})
+ eq_(o.filter(action=amo.LOG.EDIT_PROPERTIES.id).count(), 1)
class TestAdmin(TestEdit):
View
9 mkt/reviewers/templates/reviewers/includes/details.html
@@ -104,7 +104,7 @@
{% set previews = product.all_previews %}
- {% if product.description or previews or product.developer_comments %}
+ {% if product.description or previews %}
<h2 id="more-about">{{ _('Description') }}</h2>
<div class="article userinput">
<p{{ product.description|locale_html }}>{{ product.description|nl2br }}</p>
@@ -119,13 +119,6 @@ <h2 id="more-about">{{ _('Description') }}</h2>
{% endfor %}
{% endif %}
- {% if product.developer_comments %}
- <h2>{{ _('Developer Comments') }}</h2>
- <div class="prose userinput">
- <p{{ product.developer_comments|locale_html }}>{{
- product.developer_comments|nl2br }}</p>
- </div>
- {% endif %}
</div>{# /article #}
{% else %}
<h2 id="more-about">{{ _('More about this app') }}</h2>
View
9 mkt/reviewers/templates/reviewers/includes/mobile_details.html
@@ -19,19 +19,12 @@
</li>
{% endif %}
{# Mobile description section. #}
- {% if product.developer_comments or product.summary %}
+ {% if product.summary %}
<li class="expandable c">
<div class="expandcontent short">
{% if product.summary %}
<p{{ product.summary|locale_html }}>{{ product.summary|nl2br }}</p>
{% endif %}
- {% if product.developer_comments %}
- <h2>{{ _('Developer Comments') }}</h2>
- <div class="prose userinput">
- <p{{ product.developer_comments|locale_html }}>{{
- product.developer_comments|nl2br }}</p>
- </div>
- {% endif %}
</div>
<a href="#" class="showmore">{{ _('more...') }}</a>
</li>
Please sign in to comment.
Something went wrong with that request. Please try again.