Skip to content
This repository was archived by the owner on Mar 15, 2018. It is now read-only.

Commit 14fad86

Browse files
author
Andy McKay
committed
add in currency to body
1 parent 74e2514 commit 14fad86

File tree

2 files changed

+34
-15
lines changed

2 files changed

+34
-15
lines changed

apps/users/helpers.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,12 @@ def contribution_type(type):
8585

8686
@register.function
8787
def user_data(amo_user):
88-
return {'anonymous': amo_user.is_anonymous(),
89-
'pre_auth': False if amo_user.is_anonymous()
90-
else amo_user.has_preapproval_key()}
88+
anonymous, currency, pre_auth = amo_user.is_anonymous(), 'USD', False
89+
if not anonymous:
90+
preapproval = amo_user.get_preapproval()
91+
if preapproval:
92+
pre_auth = bool(preapproval.paypal_key)
93+
currency = preapproval.currency if preapproval.currency else 'USD'
94+
95+
return {'anonymous': anonymous, 'pre_auth': pre_auth,
96+
'currency': currency}

apps/users/tests/test_helpers.py

Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
import mock
77
from nose.tools import eq_
88

9+
import amo.tests
910
from amo.urlresolvers import reverse
11+
from market.models import PreApprovalUser
1012
from users.helpers import emaillink, user_link, users_list, user_data
1113
from users.models import UserProfile, RequestUser
1214

@@ -89,15 +91,26 @@ def test_user_data():
8991
eq_(u['pre_auth'], False)
9092

9193

92-
@mock.patch('users.models.RequestUser.has_preapproval_key')
93-
def test_user_data_approved(has_preapproval_key):
94-
has_preapproval_key.return_value = True
95-
u = user_data(RequestUser(username='foo', pk=1))
96-
eq_(u['anonymous'], False)
97-
eq_(u['pre_auth'], True)
98-
99-
100-
def test_anonymous_user_data():
101-
u = user_data(AnonymousUser())
102-
eq_(u['anonymous'], True)
103-
eq_(u['pre_auth'], False)
94+
class TestUserData(amo.tests.TestCase):
95+
96+
def test_user_data_approved(self):
97+
up = UserProfile.objects.create(email='aq@a.com', username='foo')
98+
PreApprovalUser.objects.create(user=up, paypal_key='asd')
99+
u = user_data(RequestUser.objects.get(pk=up.pk))
100+
eq_(u['anonymous'], False)
101+
eq_(u['pre_auth'], True)
102+
eq_(u['currency'], 'USD')
103+
104+
def test_anonymous_user_data(self):
105+
u = user_data(AnonymousUser())
106+
eq_(u['anonymous'], True)
107+
eq_(u['pre_auth'], False)
108+
eq_(u['currency'], 'USD')
109+
110+
def test_preapproval_user_data(self):
111+
up = UserProfile.objects.create(email='aq@a.com', username='foo')
112+
PreApprovalUser.objects.create(user=up, paypal_key='asd', currency='EUR')
113+
u = user_data(RequestUser.objects.get(pk=up.pk))
114+
eq_(u['anonymous'], False)
115+
eq_(u['pre_auth'], True)
116+
eq_(u['currency'], 'EUR')

0 commit comments

Comments
 (0)