Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Commit

Permalink
added version number to item link url
Browse files Browse the repository at this point in the history
  • Loading branch information
samkeen-blog committed Jul 19, 2010
1 parent fcecfb3 commit c102e83
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 4 additions & 1 deletion apps/versions/feeds.py
Expand Up @@ -10,6 +10,8 @@

from addons.models import Addon

import urllib


class VersionsRss(Feed):

Expand Down Expand Up @@ -42,7 +44,8 @@ def items(self, obj):
def item_link(self, version):
"""Link for a particular version (<item><link>)"""
# https://addons.mozilla.org/en-US/firefox/addons/versions/722
return reverse('addons.versions', args=[version.addon_id])
version_tag = urllib.quote(version.version)
return reverse('addons.versions', args=[version.addon_id]) + version_tag

This comment has been minimized.

Copy link
@jbalogh

jbalogh Jul 20, 2010

Contributor

Why aren't you putting the version number in reverse? reverse('addons.versions', args=[version.addon_id, version.version]) should come out right.

This comment has been minimized.


def item_title(self, version):
"""Title for particular version (<item><title>)"""
Expand Down
4 changes: 2 additions & 2 deletions apps/versions/tests.py
Expand Up @@ -187,12 +187,12 @@ def test_feed_elements_present(self):
assert len(doc('rss channel description')[0].text) > 0
# description doesn not contain the default object to string
desc_elem = doc('rss channel description')[0]
assert desc_elem.text.find('Content-Type:') == -1
assert 'Content-Type:' not in desc_elem
# title present
assert len(doc('rss channel item title')[0].text) > 0
# link present and well formed
item_link = doc('rss channel item link')[0]
assert item_link.text.endswith('/addon/11730/versions/')
assert item_link.text.endswith('/addon/11730/versions/20090521')
# guid present
assert len(doc('rss channel item guid')[0].text) > 0
# proper date format for item
Expand Down

0 comments on commit c102e83

Please sign in to comment.