From c102e831feed02074dd3e2e3cfe1d7a82d41139f Mon Sep 17 00:00:00 2001 From: Sam Keen Date: Mon, 19 Jul 2010 14:33:29 -0700 Subject: [PATCH] added version number to item link url --- apps/versions/feeds.py | 5 ++++- apps/versions/tests.py | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/apps/versions/feeds.py b/apps/versions/feeds.py index 91b5fd2b2d9..e33118aa250 100644 --- a/apps/versions/feeds.py +++ b/apps/versions/feeds.py @@ -10,6 +10,8 @@ from addons.models import Addon +import urllib + class VersionsRss(Feed): @@ -42,7 +44,8 @@ def items(self, obj): def item_link(self, version): """Link for a particular version ()""" # https://addons.mozilla.org/en-US/firefox/addons/versions/722 - return reverse('addons.versions', args=[version.addon_id]) + version_tag = urllib.quote(version.version) + return reverse('addons.versions', args=[version.addon_id]) + version_tag def item_title(self, version): """Title for particular version ()""" diff --git a/apps/versions/tests.py b/apps/versions/tests.py index e4c287fe2c2..38e4c8f39ef 100644 --- a/apps/versions/tests.py +++ b/apps/versions/tests.py @@ -187,12 +187,12 @@ def test_feed_elements_present(self): assert len(doc('rss channel description')[0].text) > 0 # description doesn not contain the default object to string desc_elem = doc('rss channel description')[0] - assert desc_elem.text.find('Content-Type:') == -1 + assert 'Content-Type:' not in desc_elem # title present assert len(doc('rss channel item title')[0].text) > 0 # link present and well formed item_link = doc('rss channel item link')[0] - assert item_link.text.endswith('/addon/11730/versions/') + assert item_link.text.endswith('/addon/11730/versions/20090521') # guid present assert len(doc('rss channel item guid')[0].text) > 0 # proper date format for item