add in pre-approval limits (bug 760759)

mozilla · Jun 5, 2012 · f148c02 · f148c02
1 parent 61ff117
commit f148c02
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/apps/paypal/__init__.py b/apps/paypal/__init__.py
@@ -416,6 +416,9 @@ def get_preapproval_key(data):
         'startingDate': data['startDate'].strftime('%Y-%m-%d'),
         'endingDate': data['endDate'].strftime('%Y-%m-%d'),
         'maxTotalAmountOfAllPayments': str(data.get('maxAmount', '2000')),
+        'maxAmountPerPayment': 15,
+        'maxNumberOfPaymentsPerPeriod': 15,
+        'paymentPeriod': 'DAILY',
         'returnUrl': absolutify(reverse(data['pattern'], args=['complete'])),
         'cancelUrl': absolutify(reverse(data['pattern'], args=['cancel'])),
     }

diff --git a/apps/paypal/tests/test.py b/apps/paypal/tests/test.py
@@ -504,6 +504,14 @@ def test_preapproval_patterns(self, _call):
         eq_(_call.call_args[0][1]['returnUrl'],
             absolutify(reverse(data['pattern'], args=['complete'])))
 
+    def test_preapproval_limits(self, _call):
+        _call.return_value = good_preapproval_string
+        data = self.get_data()
+        paypal.get_preapproval_key(data)
+        eq_(_call.call_args[0][1]['paymentPeriod'], 'DAILY')
+        eq_(_call.call_args[0][1]['maxAmountPerPayment'], 15)
+        eq_(_call.call_args[0][1]['maxNumberOfPaymentsPerPeriod'], 15)
+
     def test_preapproval_url(self, _call):
         url = paypal.get_preapproval_url('foo')
         assert (url.startswith(settings.PAYPAL_CGI_URL) and

diff --git a/migrations/419-drop-pre-approvals.sql b/migrations/419-drop-pre-approvals.sql
@@ -0,0 +1 @@
+UPDATE users_preapproval SET paypal_key = '', paypal_expiry = '';