create comm attachments from reviewer tools on reviews (bug 977296) #1812

Merged
merged 1 commit into from Feb 27, 2014

Projects

None yet

2 participants

@ngokevin
Member

Breaking #1607 up. Screencast

Part 1: In a waffle, use a separate template for reviewers app history that is populated by the Commbadge API rather than passing in ActivityLog objects through the view.

Part 2: Display Commbadge attachments along with the notes.

Part 3: Create Commbadge notes for all review actions.

Part 4: Create Commbadge attachments from reviewer tools.

  • When reviewing an app and adding an attachment, the attachment should be attached the the Commbadge note.

Part 5: Paginate Commbadge notes if a lot exist for a version.

@ngokevin
Member
@robhudson robhudson commented on an outdated diff Feb 27, 2014
mkt/comm/tests/test_utils_.py
from mkt.comm.models import CommunicationThread, CommunicationThreadToken
from mkt.comm.utils import (CommEmailParser, create_comm_note,
save_from_email_reply)
+from mkt.comm.tests.test_api import AttachmentManagementMixin
@robhudson robhudson commented on an outdated diff Feb 27, 2014
mkt/reviewers/tests/test_views.py
@@ -2123,8 +2109,7 @@ def test_attachment_email_requestinfo(self, save_mock):
self.post(self._attachment_form_data(num=1, action='info'))
eq_(len(mail.outbox[0].attachments), 1,
'Review attachment not added to email')
- eq_(save_mock.call_args_list,
- [mock.call(os.path.join(ATTACHMENTS_DIR, 'bacon.txt'), mock.ANY)])
+ ok_(save_mock.called)
@robhudson
robhudson Feb 27, 2014 Member

You no longer want to know what save_mock was called with?

@robhudson
Member

r+wc

@ngokevin ngokevin merged commit 315a0f0 into mozilla:master Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment