Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

paginate commbadge notes on in reviewer tools review history (bug 977325) #1814

Merged
merged 1 commit into from Mar 4, 2014

Conversation

Projects
None yet
2 participants
Contributor

ngokevin commented Feb 26, 2014

Breaking #1607 up. Screencast

Part 1: In a waffle, use a separate template for reviewers app history that is populated by the Commbadge API rather than passing in ActivityLog objects through the view.

Part 2: Display Commbadge attachments along with the notes.

Part 3: Create Commbadge notes for all review actions.

Part 4: Create Commbadge attachments from reviewer tools.

Part 5: Paginate Commbadge notes if a lot exist for a version.

  • JS pagination of notes pulling in from the Commbadge API on reviewer tools.
Contributor

ngokevin commented Feb 26, 2014

Contributor

ngokevin commented Mar 4, 2014

thanks, commbadge is nearly done. just need to guide it in. comment on the PR next time

@cvan cvan commented on an outdated diff Mar 4, 2014

media/css/devreg/reviewers.styl
+
+ }
+ .next.active + .prev:after {
+ background-color: $medium-gray;
+ border-radius: 3px;
+ bottom: 2px;
+ content: "";
+ display: inline-block;
+ height: 3px;
+ left: 2px;
+ margin: 0 2px;
+ position: relative;
+ width: 3px;
+ }
+}
+.comm-note {
@cvan

cvan Mar 4, 2014

Member

add a newline between these blocks -> more 👓 readable

@cvan cvan and 1 other commented on an outdated diff Mar 4, 2014

media/js/devreg/reviewers/reviewers_commbadge.js
@@ -9,7 +9,8 @@ define('reviewersCommbadge', [], function() {
function _userArg(url) {
// Persona user token.
- return urlparams(url, {'_user': localStorage.getItem('0::user')});
+ return urlparams(url, {'_user': localStorage.getItem('0::user'),
@cvan

cvan Mar 4, 2014

Member

add a TODO. also, won't this contain _user=undefined if the user hasn't logged in to commbadge?

@ngokevin

ngokevin Mar 4, 2014

Contributor

Yeah, it doesn't work unless we fix the login issue which was why I got around to trying out those patches.

@cvan cvan commented on an outdated diff Mar 4, 2014

requirements/prod.txt
@@ -96,7 +96,7 @@ statsd==2.0.3
suds==0.4
## Not on pypi.
--e git+https://github.com/mozilla/amo-validator.git@cde411df44cb3d4fcd763b58d9e5924dfc34df8b#egg=amo-validator
+-e git+https://github.com/mozilla/amo-validator.git@631efe1790c54eabbc3032a86916624a89da0a63#egg=amo-validator
@cvan

cvan Mar 4, 2014

Member

oops?

Member

cvan commented Mar 4, 2014

r+wc good work, mate 🎋

Contributor

ngokevin commented Mar 4, 2014

ngokevin added a commit that referenced this pull request Mar 4, 2014

Merge pull request #1814 from ngokevin/commbadger5
paginate commbadge notes on in reviewer tools review history (bug 977325)

@ngokevin ngokevin merged commit e3c0570 into mozilla:master Mar 4, 2014

@ngokevin ngokevin deleted the ngokevin:commbadger5 branch Mar 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment