Skip to content

Bug 701719: Give theme jars .xpi extension so that they have application... #335

Merged
merged 1 commit into from Oct 23, 2012

3 participants

@kmaglione

.../x-xpinstall on download and on disk.

@cvan
Mozilla member
cvan commented Aug 9, 2012

if you can update the tests, I can merge this in

@kmaglione

Updated with tests for search plugins, dictionaries, and langpacks.

@robhudson robhudson and 1 other commented on an outdated diff Aug 24, 2012
apps/files/tests/test_models.py
@@ -807,6 +810,26 @@ def test_strict_compat(self):
f = File.from_upload(upload, self.version, self.platform, data)
eq_(f.strict_compatibility, True)
+ def test_theme_extension(self):
+ upload = self.upload('theme.jar')
+ f = File.from_upload(upload, self.version, self.platform)
+ eq_(f.filename.endswith('.xpi'), True)
+
+ def test_extension_extension(self):
+ upload = self.upload('extension.xpi')
+ f = File.from_upload(upload, self.version, self.platform)
+ eq_(f.filename.endswith('.xpi'), True)
+
+ def test_langpack_extension(self):
+ upload = self.upload('extension.xpi')
+ f = File.from_upload(upload, self.version, self.platform)
+ eq_(f.filename.endswith('.xpi'), True)
@robhudson
Mozilla member
robhudson added a note Aug 24, 2012

This one and the test above it are exactly the same?

@kmaglione
kmaglione added a note Aug 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@kmaglione

I only just realized that this never got pushed when it came up on the editors list last night. Updated with the filename fix.

@robhudson robhudson merged commit 2748eaa into mozilla:master Oct 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.