This repository has been archived by the owner. It is now read-only.

List all the icons in API #342

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@darktrojan
Contributor

darktrojan commented Jun 19, 2012

see bug 731539 for discussion

@darktrojan

This comment has been minimized.

Show comment
Hide comment
@darktrojan

darktrojan Aug 7, 2012

Contributor

ping?

Contributor

darktrojan commented Aug 7, 2012

ping?

@clouserw

This comment has been minimized.

Show comment
Hide comment
@clouserw

clouserw Aug 10, 2012

Member

Kumar is going to review this next week

Member

clouserw commented Aug 10, 2012

Kumar is going to review this next week

@kumar303

This comment has been minimized.

Show comment
Hide comment
@kumar303

kumar303 Aug 10, 2012

Member

Hi. Thanks for all the change so far. Can you rebase/squash all your changes into one commit? Here is some info on how to do that https://blog.mozilla.org/webdev/2011/11/21/git-using-topic-branches-and-interactive-rebasing-effectively/

The reason it's important here is that the API is under heavy load. If we find on dev or prod that it affects performance we may need to revert the commit until it's fixed.

Member

kumar303 commented Aug 10, 2012

Hi. Thanks for all the change so far. Can you rebase/squash all your changes into one commit? Here is some info on how to do that https://blog.mozilla.org/webdev/2011/11/21/git-using-topic-branches-and-interactive-rebasing-effectively/

The reason it's important here is that the API is under heavy load. If we find on dev or prod that it affects performance we may need to revert the commit until it's fixed.

@kumar303

This comment has been minimized.

Show comment
Hide comment
@kumar303

kumar303 Aug 24, 2012

Member

The cron job and model change adds a lot of complexity. Could we start by just adding the new icon method from your first pull request and defer the cron change to another pull request? Your first patch was very close to done, it just needed to use the storage API. Thanks for all your work on this.

Member

kumar303 commented Aug 24, 2012

The cron job and model change adds a lot of complexity. Could we start by just adding the new icon method from your first pull request and defer the cron change to another pull request? Your first patch was very close to done, it just needed to use the storage API. Thanks for all your work on this.

@kumar303

This comment has been minimized.

Show comment
Hide comment
@kumar303

kumar303 Sep 6, 2012

Member

Thanks for doing another cleanup. I took a closer look at has_icon_internal() and there's no way we can check the icon dir in a loop (especially when using S3). Can you reapply the cron job patch that makes it a column in the table? Sorry, I know I said not to but we have to make this a column in the table with the kind of traffic the API gets.

Member

kumar303 commented Sep 6, 2012

Thanks for doing another cleanup. I took a closer look at has_icon_internal() and there's no way we can check the icon dir in a loop (especially when using S3). Can you reapply the cron job patch that makes it a column in the table? Sorry, I know I said not to but we have to make this a column in the table with the kind of traffic the API gets.

@darktrojan darktrojan closed this May 23, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.