Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix cancel button noop (bug 854301) #691

Merged
merged 1 commit into from

2 participants

@muffinresearch
Collaborator

Add link back to item so that cancel works.

https://bugzilla.mozilla.org/show_bug.cgi?id=854301

@cvan

the user could've gotten here from the reviews listing page, not just the detail page. I think it's logical to link them back to detail page though. I'm pretty sure there's unneeded JS that's not getting run, but don't worry about it.

@cvan
Owner

r+

@muffinresearch muffinresearch merged commit ce324af into mozilla:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 25, 2013
  1. @muffinresearch
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  mkt/ratings/templates/ratings/add.html
View
2  mkt/ratings/templates/ratings/add.html
@@ -24,7 +24,7 @@
validate=True) }}
<p class="form-footer submit-review c">
<div class="two-up">
- <a href="#" class="button fat alt back cancel">{{ _('Cancel') }}</a>
+ <a href="{{ product.get_detail_url() }}" class="button fat alt back cancel">{{ _('Cancel') }}</a>
</div>
<div class="two-up">
<button disabled type="submit" class="fat">
Something went wrong with that request. Please try again.