Skip to content

Fix amo tests following django-browserid update (bug 847956) #697

Merged
merged 1 commit into from Mar 27, 2013

3 participants

@muffinresearch
Mozilla member

No description provided.

@kumar303 kumar303 commented on the diff Mar 27, 2013
apps/users/tests/test_views.py
@@ -794,10 +794,10 @@ def test_native_persona_login(self, http_request):
settings.NATIVE_BROWSERID_VERIFICATION_URL,
verify=ANY, proxies=ANY, data=ANY, timeout=ANY,
headers=ANY)
- data = parse_qs(http_request.call_args[1]['data'])
@kumar303
Mozilla member
kumar303 added a note Mar 27, 2013

I don't understand why this was failing

@kumar303
Mozilla member
kumar303 added a note Mar 27, 2013

I see that the signature changed. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@kumar303 kumar303 and 1 other commented on an outdated diff Mar 27, 2013
apps/addons/tests/test_views.py
@@ -1017,7 +1017,8 @@ def setUp(self):
self.addon = Addon.objects.get(id=15663)
self.persona = self.addon.persona
self.url = self.addon.get_url_path()
- self.create_switch('personas-migration-completed')
+ (waffle.models.Switch.objects
+ .create(name='personas-migration-completed', active=True))
@kumar303
Mozilla member
kumar303 added a note Mar 27, 2013

why wasn't this working? It should be the same thing: https://github.com/mozilla/zamboni/blob/master/apps/amo/tests/__init__.py#L425-L430 Maybe try db=True ?

@muffinresearch
Mozilla member

This got changed in 8edac9e which caused two tests that weren't previously failing to fail. So I changed that back to what it was before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@kumar303
Mozilla member

r+wc

@muffinresearch muffinresearch merged commit 94c6068 into mozilla:master Mar 27, 2013
@muffinresearch muffinresearch deleted the muffinresearch:fix-amo-tests-django-browserid-update branch Mar 27, 2013
@cvan
Mozilla member

ah good call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.