Changed source/diff viewer shortcuts (Bug 727213) #704

Merged
merged 1 commit into from Apr 9, 2013

Projects

None yet

2 participants

Member

The keyboard shortcuts for prev/next diff/note do not work on german keyboard for example, as you need to press the ALT key to get the "[" and "]" character.

This patch changes them to "p" and "n" respectively. This should work on any latin keyboard and makes sure only one keystroke is needed.

I don't see any changes to files.js. am I missing something?

Owner

What needs to be changed in files.js?

cvan replied Apr 9, 2013

I have no idea - what's [c vs p? I don't use the file viewer.

Owner

These are the keyboard shortcuts for the file viewer.

cvan replied Apr 9, 2013

right, so why are we changing to p? I don't understand - I don't mind merging this. I just don't get whether both key combinations work or what?

@cvan cvan merged commit 350945c into mozilla:master Apr 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment