New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复ju, qu, xu, yu, yi和wu的韵母 #26

Merged
merged 4 commits into from Oct 11, 2015

Conversation

Projects
None yet
3 participants
@MingStar
Contributor

MingStar commented Oct 9, 2015

No description provided.

@mozillazg

This comment has been minimized.

Owner

mozillazg commented Oct 9, 2015

@MingStar Thanks! I'll review it as soon as possible when I have free time.

pinyin = 'v' + pinyin[2:]
elif pinyin.startswith('yi'):
pinyin = pinyin[1:]
else:

This comment has been minimized.

@mozillazg

mozillazg Oct 10, 2015

Owner

行尾有多余的空格。

pinyin = pinyin[1:]
else:
pinyin = 'u' + pinyin[1:]
return pinyin

This comment has been minimized.

@mozillazg

mozillazg Oct 10, 2015

Owner

Same here.

@@ -222,14 +222,34 @@ def test_simple_seg():
],
# 误把 yu 放到声母列表了
['', {'style': TONE2}, ['yu2']],
['', {'style': FINALS}, ['yu']],
['', {'style': FINALS}, ['v']],

This comment has been minimized.

@mozillazg

mozillazg Oct 10, 2015

Owner

这个文件里有几个行的行尾也有一些多余的空格。

@MingStar

This comment has been minimized.

Contributor

MingStar commented Oct 10, 2015

移除了多余的空格和一些空行

@mozillazg

This comment has been minimized.

Owner

mozillazg commented Oct 11, 2015

👍

mozillazg added a commit that referenced this pull request Oct 11, 2015

Merge pull request #26 from MingStar/master
修复ju, qu, xu, yu, yi和wu的韵母

@mozillazg mozillazg merged commit 8d852a2 into mozillazg:master Oct 11, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 99.123%
Details
@lbx6z

This comment has been minimized.

lbx6z commented Nov 19, 2015

v 0.8.5 到 v 0.9.3偷偷地把yu的韵母从yu换成了v?所以y既不是韵母也不是声母?问题是changelog上没有说>.<

@mozillazg

This comment has been minimized.

Owner

mozillazg commented Nov 19, 2015

@lbx6z 忘了说明详细的变动了 😰
是的,既不是声母也不是韵母😂

@mozillazg

This comment has been minimized.

Owner

mozillazg commented Nov 19, 2015

我还需要再仔细拜读一下声母韵母的规则:
http://www.edu.cn/20011114/3009777.shtml

mozillazg added a commit that referenced this pull request Nov 27, 2015

更新文档
ref #26

mozillazg added a commit that referenced this pull request Nov 27, 2015

更新文档
ref #26
@mozillazg

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment