New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TONE3 and BOPOMOFO styles #51

Merged
merged 3 commits into from Sep 24, 2016

Conversation

Projects
None yet
3 participants
@gumblex
Contributor

gumblex commented Sep 23, 2016

  • 加入注音 BOPOMOFO 及注音首字母 BOPOMOFO_FIRST 风格 #48
  • 加入音调在拼音后的 TONE3 风格并修复 TONE2 的文档 #39
  • 修复 TONE2 中 ü 标轻声的问题(像 侵略 -> qi1n lv0e4),以及去除文档中 0 表示轻声 #50
@coveralls

This comment has been minimized.

coveralls commented Sep 23, 2016

Coverage Status

Coverage increased (+0.07%) to 99.003% when pulling c837bfc on gumblex:master into 93b653f on mozillazg:master.

@coveralls

This comment has been minimized.

coveralls commented Sep 23, 2016

Coverage Status

Coverage increased (+0.07%) to 99.003% when pulling 7a2fbdb on gumblex:master into 93b653f on mozillazg:master.

@mozillazg

This comment has been minimized.

Owner

mozillazg commented Sep 23, 2016

@gumblex 太棒了 👍
麻烦给 修复 TONE2 中 ü 标轻声的问题(像 侵略 -> qi1n lv0e4) 加个测试?

@coveralls

This comment has been minimized.

coveralls commented Sep 23, 2016

Coverage Status

Coverage increased (+0.07%) to 99.003% when pulling 2148bb2 on gumblex:master into 93b653f on mozillazg:master.

2 similar comments
@coveralls

This comment has been minimized.

coveralls commented Sep 23, 2016

Coverage Status

Coverage increased (+0.07%) to 99.003% when pulling 2148bb2 on gumblex:master into 93b653f on mozillazg:master.

@coveralls

This comment has been minimized.

coveralls commented Sep 23, 2016

Coverage Status

Coverage increased (+0.07%) to 99.003% when pulling 2148bb2 on gumblex:master into 93b653f on mozillazg:master.

@mozillazg

This comment has been minimized.

Owner

mozillazg commented Sep 24, 2016

@gumblex Thanks!

@mozillazg mozillazg merged commit a357962 into mozillazg:master Sep 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 99.003%
Details
@gumblex

This comment has been minimized.

Contributor

gumblex commented Sep 29, 2016

注音转换的算法好像有严重性能问题(从 rime 抄来的 28 个正则太慢)。看起来直接用查表法比较好?

@mozillazg

This comment has been minimized.

Owner

mozillazg commented Sep 29, 2016

@gumblex 可以试验一下,看看实际的对比结果。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment